Add new StdDaoToken test: multiple votings started, transfers work co… #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyAkentiev
requested changes
Jul 20, 2018
| @@ -155,6 +155,11 @@ contract Voting_SimpleToken is IVoting, Ownable { | |||
| } | |||
| } | |||
|
|
|||
| function getPowerOf(address _who) view public returns(uint) { | |||
| return stdDaoToken.getBalanceAtVoting(votingID, _who); | |||
There was a problem hiding this comment.
А разве для isQuadraticVoting будет так же?
|
|
||
| const VOTING_TYPE_LIQUID = 4; | ||
|
|
||
| beforeEach(async() => { |
There was a problem hiding this comment.
Файл лучше назвать voting_simple_token.functional.tests.js
Длинно, но норм)
There was a problem hiding this comment.
а почему simple_token? Там же все виды создаются
AnthonyAkentiev
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rrectly #206