Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Set explicit encoding for py3k+ #2

Merged
merged 1 commit into from
Feb 14, 2017
Merged

BUG: Set explicit encoding for py3k+ #2

merged 1 commit into from
Feb 14, 2017

Conversation

neirbowj
Copy link
Contributor

Resolves #1

@Thibauth
Copy link
Owner

Thanks a lot for the fix! I was actually thinking of a slightly simpler one: if you just add from io import open at the top of the file, then the call to open can simply be replaced by open(xxx, encoding="utf8") in both Python2 and Python3 (io.open behaves the same in both versions). If this sounds good to you, would you mind updating the pull request with this change?

@neirbowj
Copy link
Contributor Author

Gladly.

@Thibauth Thibauth merged commit 3377306 into Thibauth:master Feb 14, 2017
@Thibauth
Copy link
Owner

Great, thanks again!

@neirbowj neirbowj deleted the issue1 branch February 17, 2017 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neirbowj @Thibauth @Riebeeck