Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pypi badge to readme! #35

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Abdur-rahmaanJ
Copy link

No description provided.

README.rst Outdated
@@ -1,6 +1,9 @@
MailDump
========

.. image:: https://badge.fury.io/py/maildump.svg
:target: https://badge.fury.io/py/maildump
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the idea of routing this through a third party... What about just using these URLs directly?

https://img.shields.io/pypi/v/maildump.svg
https://pypi.python.org/pypi/maildump/

I think shields.io is very similar to fury.io but I'm already using it in other projects so I'd prefer that.

About the placement, what about including it in the "MailDump" h1? IMO that placement looks pretty nice

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are using .md you are using .rst. I wanted to add the logo but rst kills README creativity

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah crap, feel free to convert the readme to markdown - nowadays pypi lets you specify that a file is gfm markdown anyway via setup.cfg:

long_description = file: README.md
long_description_content_type = text/markdown; charset=UTF-8; variant=GFM

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok wanted to avoid cloning the project on my PC, there i go XD

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't be lazy! :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants