Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golem::add_ function should allow to open the file if the file already exists #241

Closed
ColinFay opened this issue Oct 21, 2019 · 2 comments
Closed

golem::add_ function should allow to open the file if the file already exists #241

ColinFay opened this issue Oct 21, 2019 · 2 comments

Comments

@ColinFay
Copy link
Member

https://github.com/ThinkR-open/golem/blob/master/R/utils.R#L44

check_file_exist should open the file if it exists.

I think we should not suggest to override the file.
@ColinFay
Copy link
Member Author

ColinFay commented Nov 8, 2019

This should be solved by switching to fs::file_create instead of file.create

@ColinFay ColinFay mentioned this issue Nov 26, 2019
Closed
@ColinFay
Copy link
Member Author

Switching to fs::file_create() in the issue-285 branch, will implement this behaviour at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ColinFay