fix(config): unifying config manipulation #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All config manipulation now go through amend_golem_config. This allows to be sure that the !expr are not lost Close #709
There is no need to set things that are already set in the yaml
The name is already set by the function that gsub in the files so there is no need to do it one extra time
…_wd() The attr is not set before being passed to set_golem_wd() in set_golem_options()
The yaml manimpulation functions are now separated in various files
The get_golem_* didn't rely on the GOLEM_CONFIG_ACTIVE env_var
+ get_golem_wd tries golem::pkg_path + get_golem_name tries pkg_name + get_golem_version tries pkg_version
Co-authored-by: Colin Fay <colin@thinkr.fr>
Hotfix because of the dirty way we released version 0.3.3
path is now renamed pkg
All config manipulation now go through amend_golem_config. This allows to be sure that the !expr are not lost Close #709
There is no need to set things that are already set in the yaml
The name is already set by the function that gsub in the files so there is no need to do it one extra time
…_wd() The attr is not set before being passed to set_golem_wd() in set_golem_options()
The yaml manimpulation functions are now separated in various files
The get_golem_* didn't rely on the GOLEM_CONFIG_ACTIVE env_var
+ get_golem_wd tries golem::pkg_path + get_golem_name tries pkg_name + get_golem_version tries pkg_version
path is now renamed pkg
… into issue-709-reborn
- Unified param name for pkg/path - set_golem_wd() is now correctly documented
Move to here::here() for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All config manipulation now go through amend_golem_config.
This allows to be sure that the !expr are not lost
Close #709