Bugfix for posts with many replies:

If a post has more than 350 replies, Smarty would run out of memory and become unable to render the page; this change caps the reply list at 350.
ThinkUpLLC · Apr 26, 2010 · 2bf9285 · 2bf9285
1 parent ac43c0f
commit 2bf9285
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/webapp/common/class.Post.php b/webapp/common/class.Post.php
@@ -108,7 +108,7 @@ function getStandaloneReplies($username, $limit) {
         return $strays;
     }
 
-    function getRepliesToPost($post_id, $public = false) {
+    function getRepliesToPost($post_id, $public = false, $count=350) {
         $condition = "";
         if ($public)
             $condition = "AND u.is_protected = 0";
@@ -117,7 +117,9 @@ function getRepliesToPost($post_id, $public = false) {
         $q .= " LEFT JOIN #prefix#links AS l ON l.post_id = t.post_id ";
         $q .= " INNER JOIN #prefix#users AS u ON t.author_user_id = u.user_id ";
         $q .= " WHERE in_reply_to_post_id=".$post_id." ".$condition;
-        $q .= " ORDER BY follower_count desc;";
+        $q .= " ORDER BY follower_count desc ";
+        $q .= " LIMIT $count; ";
+
         $sql_result = $this->executeSQL($q);
         $posts_stored = array();
         while ($row = mysql_fetch_assoc($sql_result)) {

diff --git a/webapp/templates/post.index.tpl b/webapp/templates/post.index.tpl
@@ -32,7 +32,7 @@
         <div class="grid_23 omega append_20">
           {if $replies}
             <h2 class="subhead">
-              {if $reply_count eq 1}Reply{else}{$reply_count} Replies{/if}
+              {if $post->mention_count_cache eq 1}Reply{else}{$post->mention_count_cache} Replies{/if}
               ({$private_reply_count} private)
             </h2>
           {/if}

diff --git a/webapp/templates/public.tpl b/webapp/templates/public.tpl
@@ -38,7 +38,7 @@
               <div class="grid_7 center big-number omega">
                 <div class="bl">
                   <div class="key-stat">
-                    <h1>{$replies|@count|number_format}</h1>
+                    <h1>{$post->mention_count_cache|number_format}</h1>
                     <h3>replies in {$post->adj_pub_date|relative_datetime}</h3>
                   </div>
                 </div>