Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Smarty 3 #2048

Open
paazmaya opened this issue Jul 25, 2014 · 7 comments
Open

Migrate to Smarty 3 #2048

paazmaya opened this issue Jul 25, 2014 · 7 comments

Comments

@paazmaya
Copy link

Smarty 3 has been out since 2010. It's time to upgrade ThinkUp.
http://smarty-php.googlecode.com/svn/trunk/distribution/SMARTY_2_BC_NOTES.txt
@Ramoonus
Copy link
Contributor

what version of php are you using?

@paazmaya
Copy link
Author

Might have been the latest 5.4 available at that time....

@sarcas
Copy link
Contributor

sarcas commented Nov 28, 2014

Ah, I hit this today as well (when playing around with the thinkup.com branch). The deprecation is a PHP 5.5 issue (see the Changelog on preg_replace).

Rather than forcing and update to Smarty 3, it looks like the Smarty project recently released an update, version 2.6.28, which resolves the warnings.

I've got a branch together that updates the Smarty version, so hopefully I can get this updated soon.

sarcas added a commit to sarcas/ThinkUp that referenced this issue Nov 29, 2014
@sarcas
Issue ThinkUpLLC#2048: fix preg_replace deprecation warning
621c3fa 
PHP 5.5 has deprecated a PCRE pattern, and Smarty 2.6.26
triggers that warning on preg_replace.

Smarty's 2.6.28 release updates the library to be PHP 5.5 safe
@paazmaya
Copy link
Author

Great @sarcas !

ginatrapani added a commit that referenced this issue Jan 23, 2015
@ginatrapani
Merge pull request #2186 from sarcas/2048-fix-php55-deprecation-warnings
74aec53 
Issue #2048: fix preg_replace deprecation warning
ginatrapani pushed a commit that referenced this issue Jan 23, 2015
@sarcas @ginatrapani
Issue #2048: fix preg_replace deprecation warning
5111229 
PHP 5.5 has deprecated a PCRE pattern, and Smarty 2.6.26
triggers that warning on preg_replace.

Smarty's 2.6.28 release updates the library to be PHP 5.5 safe
@ginatrapani
Copy link
Member

Thanks again to @sarcas for updating the Smarty 2.6 version; that is now merged into master. However, I am going to keep this ticket open because I'd like to upgrade to Smarty 3 at some point (hopefully soon).

@paazmaya
Copy link
Author

That is also great! @ginatrapani

ginatrapani pushed a commit that referenced this issue Feb 3, 2015
@sarcas @ginatrapani
Issue #2048: fix preg_replace deprecation warning
d616ad2 
PHP 5.5 has deprecated a PCRE pattern, and Smarty 2.6.26
triggers that warning on preg_replace.

Smarty's 2.6.28 release updates the library to be PHP 5.5 safe
@paazmaya
Copy link
Author

paazmaya commented Feb 9, 2015

Just happened to come across this http://tech.blog.box.com/2014/09/box-open-source-introducing-brainy/
Not sure how easily to jump over in using the given fork and also not sure if the performance benefit will be similar with ThinkUp...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ginatrapani @Ramoonus @paazmaya @sarcas