Support PyG #93
Merged
Support PyG #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerwwww
reviewed
Dec 27, 2023
pygmtools/utils.py
Outdated
| """ | ||
| from torch_geometric.data import Data | ||
| assert type(G1) == Data, f"G1 must be torch_geometric.data.Data" | ||
| assert type(G2) == Data, f"G2 must be torch_geometric.data.Data" |
There was a problem hiding this comment.
Please replace assert with ValueError
rogerwwww
reviewed
Dec 27, 2023
tests/test_classic_solvers.py
Outdated
| # The testing function for networkx | ||
| def _test_pyg(graph_num_nodes, backends): | ||
| """ | ||
| Test the RRWM algorithm on pairs of isomorphic graphs using NetworkX |
rogerwwww
reviewed
Dec 27, 2023
pygmtools/utils.py
Outdated
| return K | ||
|
|
||
|
|
||
| def to_pyg(adj_matrix, backend=None): |
There was a problem hiding this comment.
Should there be "from_pyg" and "to_networkx", "to_graphml"?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 92.86% 92.81% -0.05%
==========================================
Files 20 20
Lines 7621 7667 +46
==========================================
+ Hits 7077 7116 +39
- Misses 544 551 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.