fix: crash when backing up swap partition #148
Conversation
args: -s /dev/nvme0n1p5 -o - -c -z 1048576 -L /var/log/partclone.log /dev/nvme0n1p5 is the swap partition, I noticed that in the calculate_speed function of progress.c, percent = prog->unit * copied; percent is NaN, prog->unit is Inf, so the next judgment was not successfully modified percent, which caused the retained to be the wrong value, and the strftime function crashed.
|
after this patch, some of case the progress not work like before. In one of my test, the value of complete always is 1 (one), before finish. I will try to change and reproduce your crash but not work. Do you have any other suggestion? |
I guess this has something to do with the compiler. On processors of different architectures, only x86 crashes. I traced through gdb and found that there was a problem with floating-point calculations. |
|
ok, thank you. We just add isnormal function which is from math.h to avoid float INF and NAN. Now it work well like before, I just can't make sure is also workable for your case? We release 3.17 to fix the progress issue, please give a try anytime, thank you! |
args: -s /dev/nvme0n1p5 -o - -c -z 1048576 -L /var/log/partclone.log
/dev/nvme0n1p5 is the swap partition, I noticed that in the calculate_speed function of progress.c, percent = prog->unit * copied; percent is NaN, prog->unit is Inf, so the next judgment was not successfully modified percent, which caused the retained to be the wrong value, and the strftime function crashed.