Include the NTFS Boot Record backup in the cloned image

[pfrouleau]

Include the NTFS Boot Record backup in the cloned image

This one depends on your view. A NTFS file system is 1 block smaller than the partition and a copy of the Boot Record is stored in the last sector of the partition. When we clone a NTFS file system, this extra block is not cloned. However, that block is created/modified by mkfs.ntfs, so it seem logical to include it in the image.

This commit update the code to include the extra block in the clone, by increasing the totalblock count and setting the last bit of the bitmap. This have the following effect: the restored file system have the same checksum than the original one. And if we restore the image on a partition with identical geometry than the original, we do not need to run ntfsfixboot.

[pfrouleau]

Hi @Thomas-Tsai,

it seems this pull request has not been merged into Partclone. I think it could fix the issue described in this thread:
https://forums.linuxmint.com/viewtopic.php?p=1891126#p1891126
(See the section about the 8GB partition at the bottom)

Maybe I should create a new pull request. This one is very old.

[shasheene]

Further references:

Description on the partclone-utils project for mounting partclone images: https://sourceforge.net/p/partclone-utils/tickets/3/
and also relevant is this comment from on a partclone-utils fork: prekageo/partclone-utils#2 (comment)

[shasheene]

Maybe I should create a new pull request. This one is very old.

@pfrouleau, no need to create a new PR. Instead you can very easily "rebase" your change onto the latest partclone git commit, then update this Pull Request. I have tested the following instructions (except the sanity check and push step) and it works fine:

# Add this git respository as a remote
git remote add upstream https://github.com/Thomas-Tsai/partclone
git fetch upstream
git checkout review/include_NTFS_backup_boot_sector_in_the_image
# Apply your change on the latest partclone. There is no conflicts so your commit applies cleanly!
git rebase upstream/master

# Sanity check your changes still solve the issue, update the git commit message if necessary

# Push your changes to your GitHub fork, and to the correct remote branch.
# Since you cloned from your fork the remote will be "origin" (see `git remote -v` for more information).
# This push will automatically update this Pull Request. I believe you'll need to `--force` push here.
git push origin review/include_NTFS_backup_boot_sector_in_the_image

[pfrouleau]

@shasheene Thanks for pointing out the rebase, but I am "The git guy" at work. 😉 It is just that I am not used to Github. I manage our own server on-premise. I forgot the MR would be updated if I rebased my branch. And on a side note, I prefer to use '--force-with-lease' instead of '--force' itself. And since git 2.30, we now have '--force-if-includes'.

I had to amend my previous commit to get the code to compile after the rebase on master. pc_set_bit() got a new parameter in the meantime.