This repository has been archived by the owner on Jul 3, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it is covered by ??
made `flatMap() -> Future<U>` a free function instead of a instance of `Result`
Conflicts: BrightFutures.xcodeproj/project.pbxproj
…sult 0.4.2 has not yet been pushed to CocoaPods
…e framework (just linked), but do need to be copied for the test targets
I've finished the first stab at getting rid of NSError in the framework and it has turned out quite nice, I think. One thing that I'm not so happy about yet is that I need BrightFutures/BrightFutures/Future.swift Line 485 in 9335a5c
|
public let BrightFuturesErrorDomain = "nl.thomvis.BrightFutures" | ||
|
||
/// An enum representing every possible error code for errors returned by BrightFutures | ||
public enum BrightFuturesError: ErrorType, Equatable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might consider adding an External
case to this enum
which carries an ErrorType
:
case External(ErrorType)
public var nsError: NSError {
switch self {
…
case let .External(e):
return e
}
}
This would seem to obviate the need for EitherError
, which would yield a simpler API.
… when it is not needed
…error in the BrightFuturesError type (see #53)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open questions:
Future<T, E>.succeeded(_: T)
return aFuture<T, NoError>
or aFuture<T, E>
?Either
(orEitherError
)?Todo: