Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stored, sent and received data assets are always processed #58

Closed
wants to merge 66 commits into from
Closed

Stored, sent and received data assets are always processed #58

wants to merge 66 commits into from

Conversation

ezavgorodniy
Copy link
Collaborator

The PR is copied and manually applied from #18, for any discussions if it help to clarify please take a look at the original

aceg1k
aceg1k commented on Jun 29, 2021
Hi,

thank you very much for your great work on this project, I hope it is still active and open for pull requests.

Rationale
Whenever data assets are stored, sent or received by a technical asset they are also processed in some way by that technical asset. This leads to tight coupling of data_assets_processed with data_assets_stored, data_assets_sent and data_assets_received (relating to both, outgoing and incoming communication links). IMHO data_assets_processed is of almost no practical use, when a data asset processed is not stored and not transferred somewhere.

Proposal
Infer data_assets_processed based on data assets stored and data assets used in outgoing and incoming communication links and do not require data_assets_processed to be set and continuously maintained.

As a stored data asset always implies a processed data asset some of the code became redundant and was removed.

I look forward to your feedback!

joreiche and others added 30 commits December 4, 2023 14:39
@joreiche
fixed typos and warnings
28e6264
@joreiche
fixed deprecaed and other warnings; fixed spelling
98882e0
@joreiche
made file paths cross-platform; eliminated IDE warnings; reformatted …
7f9f45d 
…some code for readability
@joreiche
implemented multi-yaml support
18585ce
@joreiche
added support for directly pointing at the repo demo folders when cre…
7a5366b 
…ating stub and example models
@joreiche
add install mechanism
a3baeea
@joreiche
replace plugins with system calls to regular binaries
0233bc4
@joreiche
modify builtin risks to use model as input parameter
c7f4eba
@joreiche
- made Dockerfile and Dockerfile.local consistent
ed97925 
- addressed snyk vuln reports
- added resolution of home dir (~, $HOME) for paths passed as command line arguments for ease of use in goland build configs
@joreiche
converted parse test to go-style testing
8c2e7b0
@joreiche
moved to go-style folder structure
0785567
@joreiche
merged Yevhen's changes
273a867
Fix comment
2ffb181
Move create-stub-model, create-example-model, create-editing-support …
2b634f1 
…to cobra implementation; add flags for already ported commands
Small cleanup
9619c24
Migrate print license and print 3rd party to cobra
86a28df
@joreiche
introduced config
7af8540
Move parsing types closer to type definition
4977664
@ezavgorodniy
Merge pull request #2 from joreiche/parse-types
da977d6 
Move parsing types closer to type definition
Move out parsing model code closer to model definition
b72a226
Return error instead of panicking
4d8b398
@joreiche
converting maps using iskCategory as index to use RiskCategory.Id ins…
f4b8aef 
…tead to allow marshaling the data to pass to plugins
@joreiche
committing mising file for last commit
5ce843a
@joreiche
fixed marshaling/unmarshaling parsed model struct from/to json
01186a9 
fixed running raa plugin
Move server related files into package
324c639
@ezavgorodniy
Merge pull request #3 from joreiche/move-server
13fda7c 
Move server related files into package
@joreiche
resolved circular dependencies
50023fc
@joreiche
Merge branch 'master' of github.com:joreiche/threagile
8f86b3a
@joreiche
completed merge
dee5491
@joreiche
implemented config file loading and handling
bbe2aea
Yevhen Zavhorodnii and others added 27 commits January 5, 2024 13:09
Refactor macros
6f5de2b
Use parameters instead of context
c490c6b
Move logic to packages
e4857c2
Remove panic and global variables
a45ab19
Remove accidentally uploaded file
6cdea6d
Adjust documentation according to changes
87d8033
Inline calls to dot
3713215
Restore reading config file
87ab8e6
Move colors package to report package
d6bb1c0
Reshuffle files to avoid too much logic inside parsed model, parsedMo…
f42969e 
…del shall be only parsed input model information and not deal with applying risks
Use go interfaces to specify built in risk rules, move custom risk ru…
3329cd5 
…les out of parsed model
Tidy up go mod
77bc549
@joreiche
- added list of contributors in addition to author to schema and inpu…
8f26d96 
…t structure

- added application description to schema and input structure
- added contact information to author and contributors to schema and input structure
- eliminated globals
=> TODO: add the added items to the generated report
@joreiche
made sure to propagate build timestamp
3e61f05
@joreiche
made sure to omit empty fields what marshaling inpuyt structs
8967685
@joreiche
fixed config file loading
b35e4e9
@joreiche
improved model merging for split model yaml import
dc8d4b0
@joreiche
improved string list and multi-line merging
3d59ffc
@joreiche
fixed docker run for local docker file
ac5b4c4
@joreiche
- added gosec workflow
6e23605 
- resolved issues flagged by gosec
@joreiche
trying to persuade Anchore to use the local code base rather than the…
a020fb4 
… remote repo
@joreiche
upgraded codeql upload action to v2 according to deprecation notice
b6bb2fb
@joreiche
upgraded codeql upload action to v3 according to new deprecation noti…
f03ea81 
…ce for v2 lol
@joreiche
manually merged pull request Threagile#53
eda8518
@joreiche
resolved grype issues:
6af115d 
- forced package update for packages with available upstream fixes
- configured grype to ignore issues in packages without available fixes
@joreiche
ignoring grype build errors
a7a61c6
Stored, sent and received data assets are always processed
033fc8a
@ezavgorodniy
Copy link
Collaborator Author

wrong location

@joreiche joreiche deleted the pr-18-transfer branch February 2, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ezavgorodniy @joreiche