submodule: docson: Switch to new 360-master branch #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've made a hidden version of this branch on readthedocs: https://standard.threesixtygiving.org/en/mw-docson-widget-update/reference/#json-format the only issue I've found is that the docjson iframe now has 2 scrollbars (firefox & chrome, windows 10):
I think it might potentially be this bit of code that needs updating to take into account the new line height caused by the new subtitle. |
Switch to 360-master branch to tracks changes in the ODSC docson fork that are for threesixtygiving. Fixes #281
michaelwood
force-pushed
the
mw/docson-widget-update
branch
3 times, most recently
from
cd41794
to
876166a
Compare
The docson widget tries to control its own height properties and uses window events, this results in additional unnecessary scrollbars in the container div which aren't needed as they already exist on the iframe. We change to using the div simply as a way to easily reference the iframe element. As the id for the iframe contains punctuation and we may want to use this style elsewhere.
michaelwood
force-pushed
the
mw/docson-widget-update
branch
from
876166a
to
ce068d0
Compare
drkane
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to 360-master branch to tracks changes in the ODSC docson fork
that are for threesixtygiving.
Fixes #281