Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make YearWeek implement Temporal #165

Merged
merged 2 commits into from Nov 29, 2020
Merged

Make YearWeek implement Temporal #165

merged 2 commits into from Nov 29, 2020

Conversation

jodastephen
Copy link
Member

@jodastephen jodastephen commented Nov 29, 2020

Fixes #115

jodastephen and others added 2 commits December 9, 2018 16:10
* test: cover YearWeek.plus()

* test: cover YearWeek.with()

* test: cover YearWeek.until()

* test: cover YearWeek.minus()

* test: add more cases for YearWeek.until()

* fix: YearWeek.until() returning wrong values
@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@33ce201). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #165   +/-   ##
=========================================
  Coverage          ?   88.65%           
  Complexity        ?     2306           
=========================================
  Files             ?       57           
  Lines             ?     4327           
  Branches          ?      620           
=========================================
  Hits              ?     3836           
  Misses            ?      331           
  Partials          ?      160           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ce201...f9e32ad. Read the comment docs.

@jodastephen jodastephen merged commit cc42d32 into master Nov 29, 2020
@jodastephen jodastephen deleted the topic/year-week branch November 29, 2020 22:55
@jodastephen jodastephen added this to the v1.6 milestone Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Question / Can YearWeek and others implement Temporal?
2 participants