Skip to content
This repository has been archived by the owner on Dec 10, 2018. It is now read-only.

Commit

Permalink
Fix the misusing of default_spec with a string format instead of a pa…
Browse files Browse the repository at this point in the history
…rameter and modify some code which is not pythonic.
  • Loading branch information
OctavianLee committed Jul 10, 2015
1 parent 4fe4bf6 commit 892b6b8
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions thriftpy/thrift.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ class TMessageType(object):


class TPayloadMeta(type):

def __new__(cls, name, bases, attrs):
if "default_spec" in attrs:
attrs["__init__"] = init_func_generator(attrs.pop("default_spec"))
Expand All @@ -79,12 +80,13 @@ def gen_init(cls, thrift_spec=None, default_spec=None):
if thrift_spec is not None:
cls.thrift_spec = thrift_spec

if "default_spec" is not None:
if default_spec is not None:
cls.__init__ = init_func_generator(default_spec)
return cls


class TPayload(with_metaclass(TPayloadMeta, object)):

def read(self, iprot):
iprot.read_struct(self)

Expand All @@ -110,6 +112,7 @@ def __ne__(self, other):


class TClient(object):

def __init__(self, service, iprot, oprot=None):
self._service = service
self._iprot = self._oprot = iprot
Expand Down Expand Up @@ -167,7 +170,7 @@ def _recv(self, _api):

# check throws
for k, v in result.__dict__.items():
if k != "success" and v is not None:
if k != "success" and v:
raise v

# no throws & not void api
Expand Down Expand Up @@ -289,6 +292,7 @@ def call():


class TProcessorFactory(object):

def __init__(self, processor_class, *args, **kwargs):
self.args = args
self.kwargs = kwargs
Expand Down

0 comments on commit 892b6b8

Please sign in to comment.