Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/debug details #37

Closed

Conversation

marcoabensur
Copy link

No description provided.

Copy link
Member

@LucasHaug LucasHaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Só deixei uns comentários X auahauhauahau. Mas boa, a gente realmente precisa completar essa seção.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@@ -393,6 +393,7 @@ define VS_LAUNCH
"request": "launch",
"servertype": "stutil",
"cwd": "$${workspaceRoot}",
"gdbPath": "${ARM_GCC_PATH}/arm-none-eabi-gcc",
Copy link
Member

@LucasHaug LucasHaug Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não deveria ser gdb aqui @marcoabensur??

Suggested change
"gdbPath": "${ARM_GCC_PATH}/arm-none-eabi-gcc",
"gdbPath": "${ARM_GCC_PATH}/arm-none-eabi-gdb",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdade, devia

"cStandard": "c99",
"cppStandard": "c++14",
"intelliSenseMode": "clang-x64"
"intelliSenseMode": "linux-gcc-arm"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"intelliSenseMode": "linux-gcc-arm"
"intelliSenseMode": "gcc-arm"

@LucasHaug
Copy link
Member

@marcoabensur só pra fechar isso, deixei uns comentários a mais ali

Copy link
Member

@LucasHaug LucasHaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nossa eu tinha uns comentários antigos que ficaram pendentes e nunca soltei uhasuhasuh

@@ -393,6 +393,7 @@ define VS_LAUNCH
"request": "launch",
"servertype": "stutil",
"cwd": "$${workspaceRoot}",
"gdbPath": "${ARM_GCC_PATH}/arm-none-eabi-gcc",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E tava vendo aqui, acho que não precisa do caminho completo

Suggested change
"gdbPath": "${ARM_GCC_PATH}/arm-none-eabi-gcc",
"gdbPath": "arm-none-eabi-gdb",

@@ -403,6 +404,7 @@ define VS_LAUNCH
"request": "launch",
"servertype": "jlink",
"cwd": "$${workspaceRoot}",
"gdbPath": "${ARM_GCC_PATH}/arm-none-eabi-gcc",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"gdbPath": "${ARM_GCC_PATH}/arm-none-eabi-gcc",
"gdbPath": "arm-none-eabi-gdb",

@Eduardo-Barreto
Copy link
Member

Opa, com a migração pra cmake acho que essa PR não faz mais tanto sentido... fechando por aqui

a parte da documentação ainda é importante, então criei a issue #48 pra ser feito no futuro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants