Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mudança nomes dos robôs #16

Merged
merged 22 commits into from
Mar 30, 2021
Merged

Mudança nomes dos robôs #16

merged 22 commits into from
Mar 30, 2021

Conversation

FelipeGdM
Copy link
Member

@FelipeGdM FelipeGdM commented Mar 27, 2021 •
edited

Salve salve garotada

Sem mais delongas, aqui está a mudança que eu estava devendo. Os nomes dos robôs foram trocados de modo a obedecer a regra

/[yellow|blue]_team/robot_[0..2]

Em outras palavras, a numeração dos robôs passou a ser de 0 até 2, ao invés de 1 até 3 como originalmente. Outra mudança é a remoção de referências "friends" e "foes" para "time amarelo" e "time azul"

No mais, essas foram as mudanças. Tanto a documentação quanto o changelog foram atualizados de acordo

Fiquem bem e mantenham-se hidratados

@FelipeGdM FelipeGdM self-assigned this Mar 27, 2021
LucasHaug
LucasHaug requested changes Mar 27, 2021
View reviewed changes
Copy link
Member

@LucasHaug LucasHaug left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detalhe, mas dá pra atualizar o ano da llicença aqui também pra 2021.

Não consigo comentar no arquivo, mas acho que seria interessante mudar os arquivos team_yellow.material e team_blue.material pra seguir o padrão de numeração dos robôs. Aí tem que mudar os lugares que isso isso né, óbvio.

E já que é uma PR pra mudar nome, acho que daria pra mudar isso daqui:

/yellow_team/robot[0..2]/vss_robot_left_controller/command

Acho que não precisa ali do vss_robot_, já tá no namespace de um robô e do time, acho que daria pra tirar isso, deixa mais curto o nome.

scripts/vision_proxy.py Show resolved Hide resolved
README.pt-br.md Show resolved Hide resolved
launch/simulation_robot.launch Show resolved Hide resolved
LucasHaug
LucasHaug requested changes Mar 27, 2021
View reviewed changes
Copy link
Member

@LucasHaug LucasHaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precisa mudar no keyboard.py também o nome do tópico do diff_drive (nisso eu vi que nele ta falando nRFDongle também). Aí seria bom colocar essas coisas no changelog também acho né?

README.pt-br.md Outdated Show resolved Hide resolved
README.pt-br.md Outdated Show resolved Hide resolved
FelipeGdM and others added 3 commits March 27, 2021 16:02
@FelipeGdM @LucasHaug
Update README.pt-br.md
5321897 
Co-authored-by: Lucas Haug <39196309+LucasHaug@users.noreply.github.com>
@FelipeGdM @LucasHaug
Update README.pt-br.md
38c1266 
Co-authored-by: Lucas Haug <39196309+LucasHaug@users.noreply.github.com>
@FelipeGdM
🐍 Update keyboard_node w/ name changes
f8fbf0c
LucasHaug
LucasHaug requested changes Mar 28, 2021
View reviewed changes
Copy link
Member

@LucasHaug LucasHaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dá pra atualizar o ano da licença no settings.json também.

Uma coisa que não tem nada a ver com essa PR, mas falando aqui pra não esquecer, tem algumas coisas faltando nos README principais na parte da estrutura das pastas, algumas não tão lá.

CHANGELOG.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
scripts/keyboard_node.py
Comment on lines 234 to 235

# args = parser.parse_args(myargv)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não tem muito a ver com essa PR, mas tem uns códigos comentados aqui e mais pra cima que daria pra tirar

scripts/keyboard_node.py
@@ -29,7 +29,7 @@
ROBOTS = 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mais pra cima na docstring desse arquivo tem um referência ao VSSFirmware que daria pra tirar acho, já que ele não é público que nem esse repo ahahahahahhaha

@LucasHaug LucasHaug mentioned this pull request Mar 28, 2021
Open
FelipeGdM and others added 3 commits March 28, 2021 21:54
@FelipeGdM @LucasHaug
Update README.md
dccb838 
Co-authored-by: Lucas Haug <39196309+LucasHaug@users.noreply.github.com>
@FelipeGdM
Update Changelog with controllers topic names
0be5523
@FelipeGdM
Update year in copyright notice
0ad5c97
lucastrschneider
lucastrschneider reviewed Mar 29, 2021
View reviewed changes
Copy link
Collaborator

@lucastrschneider lucastrschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Só um detalhezinho, tava bugando a formatação em uma das partes, ai só movi o underscore pra fora do strike e funcionou

image

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.pt-br.md Outdated Show resolved Hide resolved
FelipeGdM and others added 2 commits March 29, 2021 22:25
@FelipeGdM @lucastrschneider
Update CHANGELOG.pt-br.md
07f8872 
Co-authored-by: Lucas Schneider <50970346+lucastrschneider@users.noreply.github.com>
@FelipeGdM @lucastrschneider
Update CHANGELOG.md
557bc22 
Co-authored-by: Lucas Schneider <50970346+lucastrschneider@users.noreply.github.com>
lucastrschneider
lucastrschneider previously approved these changes Mar 30, 2021
View reviewed changes
Copy link
Collaborator

@lucastrschneider lucastrschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

LucasHaug
LucasHaug approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@LucasHaug LucasHaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Só mudei a numeração ali do README do urdf antes aqui.

@FelipeGdM FelipeGdM merged commit 816a916 into develop Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasHaug LucasHaug LucasHaug approved these changes

@lucastrschneider lucastrschneider lucastrschneider left review comments

@Tocoquinho Tocoquinho Awaiting requested review from Tocoquinho

@lucas-pvg lucas-pvg Awaiting requested review from lucas-pvg

@GabrielCosme GabrielCosme Awaiting requested review from GabrielCosme

@RicardoHonda RicardoHonda Awaiting requested review from RicardoHonda

@leticiakimoto leticiakimoto Awaiting requested review from leticiakimoto

Assignees

@FelipeGdM FelipeGdM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FelipeGdM @LucasHaug @lucastrschneider