copy album artist to album artist #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you had a chance to review the PR yet? It would be great to get this merged if it's looking good. Thanks |
|
@pinkforest This looks good to merge if you're interested. |
|
Hey thanks for taking time to chase these both of you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I hope that this PR finds you well. Thanks for this nice library.
I noticed that the album artist string appears to get copied to the artist, rather than the album artist when dyn tags are used. I believe I have corrected the issue. I tried the supplied test with and without the change and it appears to fail without the changes. Do you think this would make sense to change?
Thanks