pass through wav/aiff support from id3. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id3 added format detection logic to Tag::read_from_path, so the same API now works for mp3/wav/aiff. the existing a.wav asset had no tag chunk in it, which caused the existing test case to fail (the other assets have empty or trivial tags). so a.wav and a.aif both have empty tag chunks to start with. TianyiShi2001#22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id3 added format detection logic to Tag::read_from_path, so the same API now works for mp3/wav/aiff. the only thing needed was a version bump and some test cases.
the existing a.wav asset had no tag chunk in it, which caused the existing test case to fail (the other assets have empty or trivial tags). so a.wav and a.aif both have empty tag chunks to start with.
#22