getIndex filter #1452
Merged
getIndex filter #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is `wiki.parseTextReference()` the appropriate way?
| @@ -0,0 +1,32 @@ | |||
| /*\ | |||
| title: $:/core/modules/filters/getIndex.js | |||
There was a problem hiding this comment.
It's inconsistent to use "getIndex"; all the other two word filters just concatenate lower case words (eg, "removeprefix", "moduletypes"). The filename needs changing too.
* renamed to all lowercase * added documentation * added examples
|
Looks good - @aelocson are the docs changes OK? |
|
code, docs and demo updated as suggested |
|
Thanks @tobibeer |
exports.getIndex = function(source,operator,options) {
...
};It should be getindex. |
|
@BramChen, thanks for being watchful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at #1375, respectively #1375 (comment), for a data tiddler, returns the value at the index specified in the operand.
<$list filter="[[SomeData]getindex[someIndex]]"/>demo: http://tbdemo.tiddlyspot.com/#Index%20Filter