20230803 - minor edits #7661
Merged
20230803 - minor edits #7661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pmario
reviewed
Aug 3, 2023
|
|
||
| String operators are [[filter operators|Filter Operators]] that interact with strings. | ||
|
|
||
| <<list-links "[tag[String Operators]]">> |
There was a problem hiding this comment.
I would prefer: <<list-links "[tag[String Operators]]" class:"multi-columns">> which looks like this. Similar to WikiText
There was a problem hiding this comment.
only for those with many items in the list
There was a problem hiding this comment.
👍 Agreed and done!
pmario
reviewed
Aug 3, 2023
| tags: | ||
| title: Contributor License Agreement | ||
| type: text/vnd.tiddlywiki | ||
|
|
||
| Like other OpenSource projects, TiddlyWiki5 needs a signed contributor license agreement from individual contributors. This is a legal agreement that allows contributors to assert that they own the copyright of their contribution, and that they agree to license it to the UnaMesa Association (the legal entity that owns TiddlyWiki on behalf of the community). | ||
| Like other OpenSource projects, TiddlyWiki5 needs a signed contributor license agreement from individual contributors. This is a legal agreement that allows contributors to assert that they own the copyright of their contribution, and that they agree to license it to the [[UnaMesa|https://unamesa.org/]] Association (the legal entity that owns TiddlyWiki on behalf of the community). |
There was a problem hiding this comment.
If we have identical external links imo it's better to create a new tiddler: UnaMesa tagged: Definitions which contain a brief info about the organisation which then links to the external links. IMO we want to keep users on the page instead of sending them to external sites.
This may also be true for the "History of TiddlyWiki" tiddler and the external links.
There was a problem hiding this comment.
Added an UnaMesa tid with some summary info from the site, tweaked this and TiddlyHistory
pmario
reviewed
Aug 3, 2023
| @@ -1,10 +1,10 @@ | |||
| created: 20130825161100000 | |||
| modified: 20200104111952539 | |||
| modified: 20230803051056946 | |||
| tags: Definitions | |||
| title: TiddlyFox | |||
| type: text/vnd.tiddlywiki | |||
|
|
|||
There was a problem hiding this comment.
IMO this tiddler should start with
<<.deprecated-since "FireFox 57" "Saving">>
There was a problem hiding this comment.
The links at line 13ff are broken. @Jermolene -- I think they should be removed
There was a problem hiding this comment.
Depreciation added (here and other TiddlyFox tid).
pmario
reviewed
Aug 3, 2023
| @@ -14,7 +14,7 @@ The <<.def tag-pill>> [[macro|Macros]] generates a static tag pill showing a spe | |||
| ;element-tag | |||
| : The element name to be used for the pill (defaults to "span") | |||
| ;element-attributes | |||
| : Additional attributes for the pill element | |||
| : Additional attributes for the pill element | |||
There was a problem hiding this comment.
Oops! I had thought about rewriting the sentence, and missed that.
pmario
reviewed
Aug 3, 2023
| @@ -1,12 +1,12 @@ | |||
| created: 20140103134551508 | |||
| modified: 20171113131640857 | |||
| modified: 20230803051340676 | |||
| tags: [[Saving with TiddlyFox]] | |||
| title: Saving with TiddlyFox on Android | |||
| type: text/vnd.tiddlywiki | |||
|
|
|||
There was a problem hiding this comment.
Sadly this tiddler also needs to start with <<.deprecated-since "FireFox 57" "Saving">>
There is no way to save with FF for Android using browser addOns at the moment. As soon at it will be possible I'll probably make the file-saver AddOn compatible. Till then it does not work anymore.
pmario
reviewed
Aug 3, 2023
| @@ -5,22 +5,22 @@ created: 20131221085742684 | |||
| delivery: Browser Extension | |||
| description: Browser extension for older versions of Firefox | |||
| method: save | |||
| modified: 20200507105421421 | |||
| modified: 20230803051244464 | |||
| tags: Saving Firefox | |||
| title: Saving with TiddlyFox | |||
| type: text/vnd.tiddlywiki | |||
|
|
|||
There was a problem hiding this comment.
Imo this tiddler should only contain: <<.deprecated-since "FireFox 57" "Saving with FireFox">>
and with a new PR it should link to a new tiddler "Saving with FireFox", which needs to be written, using the elements which still work as described here.
Once "Saving with FireFox" is done, the existing tiddler "GettingStarted - Firefox" should transclude it. It transcludes "this tiddler" at the moment.
pmario
reviewed
Aug 3, 2023
| @@ -0,0 +1,11 @@ | |||
| See Also: | |||
There was a problem hiding this comment.
IMO the See Also field is a typo :)
There was a problem hiding this comment.
See examples from pending PR: Fix and extend tag picker functions #7548
There was a problem hiding this comment.
Valid, I probably should have named the field my-field or something less instructive.
Very much approve of #7548, I'll recind this tid.
pmario
reviewed
Aug 3, 2023
| @@ -0,0 +1,11 @@ | |||
| See Also: | |||
There was a problem hiding this comment.
See examples from pending PR: Fix and extend tag picker functions #7548
| @@ -38,7 +38,7 @@ The content of the `<$button>` widget is displayed within the button. | |||
| |popup |Title of a state tiddler for a popup that is toggled when the button is clicked. See PopupMechanism for details | | |||
| |popupTitle |Title of a state tiddler for a popup that is toggled when the button is clicked. In difference to the <<.attr popup>> attribute, ''no'' TextReference is used. See PopupMechanism for details | | |||
| |popupAbsCoords |<<.from-version "5.2.4">> If set to ''yes'' writes absolute coordinates to the tiddler referenced by the <<.attr popup>>. If set to ''no'' (the default) uses relative coordinates. See [[Coordinate Systems]] for details | | |||
| |aria-label |Optional [[Accessibility]] label | | |||
| |aria-label |Optional <<.dlink-ex Accessibility to:https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA>> label | | |||
There was a problem hiding this comment.
I think there should be a tiddler Accessibility tagged: Definitions with some info and the external link. We should keep users on the page
There was a problem hiding this comment.
Agreed, though I'm not sure I'm up to creating an Accessibility in Tiddlywiki page, as I feel there should be more information there than I can provide.
There was a problem hiding this comment.
I think it would be OK to create the tiddler, tag it and then simply add
To learn more about accessibility visit: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA
So the link is not hidden behind an alias. So users know what they click on. @Jermolene What do you think?
as per @pmario's suggestion about long content lists
As per @pmario's suggestion re:depreciation.
Mistaken inclusion of unedited file.
As per @pmario's suggestion re:depreciation
See TiddlyWiki#7548 for better implementation.
Recinded.
Adjusted to point to new UnaMesa tid
Adjusted to point to UnaMesa tid.
|
It seems you accidentally deleted 2 tiddlers
|
You'd think PRs would only include edited files, and deleting a file would remove it from the PR, but turns out it's the whole repo instead. Oops.
|
@Jermolene -- looks good to me. -- You only should have a closer look at the TiddlyFox related tiddlers. See my inline comments |
…that can sometimes interfere with apis (TiddlyWiki#8152)" This reverts commit 6910be7.
* Initial Commit * Improve plugin tests Fixes TiddlyWiki#8209 * Fix RSOE * Fix extraneous copy to clipboard at startup
* refactor: default PageTemplate -> DefaultLayout * refactor: DefaultLayout -> StandardLayout * i18n: Default ~PageTemplate -> Standard Layout
* Improve traditional chinese translation of "Standard Layout"
Improves the continuity of our GitHub history
* Add defaultHeaders flag that controls helpful default heders that can sometimes interfere with apis * Bump version number * rename parameter to useDefaultHeaders, and catch one location where the default was not being set properly. * Use a better comparision operator * remove bad change
* Add XLSX import spec for demo real estate spreadsheets * Fix fieldname * Improve map pin * RealEstate demo: Set lat, long, price fields to be numeric * Clean up Flickr demo * Update geomap widget to refresh properly * Add Leaflet MasterCluster plugin * Setup the marker cluster plugin * Rearrange real estate demo * Reduce default cluster radius * Beginnings of real estate demo * Fix interpretation of HTTP status codes * Real estate demo: Make columns hideable * Real estate demo: sortability * Real estate demo: search and limit * Fix typo * Fix lat long transposition * Fix startup ordering * Add geolookup operator * Real Estate Demo: Add support for computed columns * Real estate demo: Increase result limit * Remove demo data * Track map pan and zoom state in a state tiddler * WIP * Use geojson extension for geojson file * Use geojson extensions for another geojson file * Split demo from the geospatial plugin into its own edition * Add build targets required by ./bin/site-build.sh... ... when building the geospatial edition as the main edition, making it easier to find on Vercel * CI Fixes * Fix default tab * Rearranging geospatial plugin vs. edition * More refactoring between demo and plugin * Start of plugin docs * Display GeoJSON properties on click * Fix layer lookup demo * Restore XLSX Utils plugin and dependencies * Cleanup docs * Remove 5.2.8 release note * Remove 5.2.8 release note * Docs update * Fix minor refreshing bug for geomap widget * Docs updates * Add jsonset operator * Add geonearestpoint operator * jsonset: support for other data types and documentation * Add logo * Add link to preview build * jsonset: add support for assigning JSON strings * Fix nonstandard initialisation code for fill/parameter/slot widgets * Introduce testcase widget so that we can reuse testcases as documentation examples There's still a bit to do: adding tabs to the source panel of the testcase display, and tweaking the CSS. * Update logo * Testcasewidget: Add tabs for switching between source tiddlers * Testcase appearance tweaks * Switch to fluid-fixed layout * Docs for the testcase-transclude and testcase-view widgets * Split docs into separate tabs * Extend testcase-view to be able to view other fields * Extend default testcase template to show all fields of payload tiddlers * Add some geomap examples * Fix testcase rounded corners * Add a geomap layer demo * Add favicon * Switch from building the geospatial plugin as the main build back to tw5.com To make it easier to get to the documentation for the new features * Remove obsolete comment * Remove geospatial plugin from tw5.com build * Fix build link * Add note about core enhancements included in this branch * Refactor data widget implementation To avoid code duplication * Integrate test cases with the docs * Remove erroneously pasted docs material * Remove erroneously copied olc-encode tests within old-decode test case * Refactor compound tiddler handling into data widget And add some tests for the data widget * Default test case template tweaks * Move Flickr macros into geospatial plugin from the demo edition * FlickrDemo: Simplify UI * FlickrMacros: Use a template to define photo tiddler fields * Remove geospatial plugin from prerelease default tiddlers * Extend Flickr helpers to support photoTiddlerTemplate parameter * Update modification times of doc tiddlers So that they are at the top of the recent tab * Update 5.3.0 release note * Remove custom CI step for this branch * Restore standard sitetitle * Flickr macro docs * Rename $:/tags/GeoLayer to $:/tags/GeoFeature And make sure that it works with all GeoJSON features, not just polygons * More test data (from leaflet.js) * Captions should be transcluded, not viewed raw * Make HTTP handler use wiki of widget that sent the message * Switch testcase widget to use an intrinsic template Makes things much simpler * Complete Flickr demos * Extend geonearestpoint operator to work with feature collections * Extend realestate demo to show data on nearest volcano * Flickr macros: fix pagination after first page Make sure that the widget we create to run the actions also has access to the event handlers attached to the rootwidget. * Real estate demo: Fix nearest volcano * Testcase docs update * Testcase template: put title at the top and remove header row * Docs correction * New geonearestpoint test case * Make test cases editable * Test case default template: Always put "Output" tab first * Initial Commit * HttpClient object shouldn't need to know about events * Add support for cancelling HTTP requests * Make the number of outstanding HTTP requests available in a state tiddler * Add a network activity button Click it to cancel outstanding requests * WIP * Fix typo Thanks @btheado Co-authored-by: btheado <brian.theado@gmail.com> * Data widget: parse carriage returns in compound tiddlers * Fix crash when cancelling more than one HTTP request Thanks @saqimtiaz * Further fixes to cancelling outstanding HTTP requests * Don't have data widget rendering its own JSON Making the data widget render its raw JSON (introduced in 683ec33) was a bad idea as it messes up the innerwiki use of the data widget. Instead we use the testcase widget with a special template to render the raw JSON of the payload of a testcase, thus giving us a way to test the data widget * Fix missed docs update * Introduce geolayer widget for specifying layers for geomap * Fix breaking tests * Remove docs references to obsolete widgets * Tests for geounion, geointersect and geodifference * Support for multiple base layers * Make the layers control visible which allows the base layer to be chosen, and individual overlay layers to be hidden * Add tiddlers tagged $:/tags/GeoBaseLayer to define some useful map base layers * Add geobaselayer widget to define base layers * Add a satellite base layer and another terrain base layer * Add a note where to get more base layers * Docs update * Geomap widget: fix default base layer rendering * Add startPosition and layersPanel attributes to geomap widget * Update geolayer widget docs with missing attributes * Add interactive demos for geounion, geodifference, geointersection * Open geofeature and geomarker maps on the bounds of their content * Move settings from demo into plugin Because now the Flickr macros are part of the plugin * Icon for geospatial plugin * Fix missing body * Flickr Demo typo * Docs update * Add support for draggable markers * Removed accidentally committed file * Remove unwanted log * Add support for tm-request-geolocation message * Fix typo * Fix bug when fitting to non-extistent bounds * Update main wiki greeting * Use "Flickr helpers" instead of "Flickr macros" * File renames for 05d3271 * Fix testcase widget example Thanks @btheado * Fix testcase widget refreshing * Fix failing tests from 03b6413 * Docs: Clarify that template must be in the payload * Testcase widget: Exclude tab state tiddlers See TiddlyWiki#7406 (comment) Thanks @btheado * Remove obsolete setquerystring operator Instead we have the query- parameters to the http request message * Remove obsolete change to --setfield command * Fix tiddler name typo * Initial Commit * Add note to preview build * Fix whitespace and indenting Thanks @pmario * Fix crash with unset $tiddler attribute on <$data> widget Thanks @CodaCodr * Remove Stamen baselayers They have stopped making them available for free - see https://maps.stamen.com/stadia-partnership/ * Disable test that won't run in browser CI * Disable broken tests * Update olc-encode.tid (TiddlyWiki#7885) Correct spelling * Don't duplicate "description" field in test cases * Use different background colours for nested testcase widgets * Extend the testcase widget to run tests * Add testcases to control panel * Add a view template body template to render testcase tiddlers * Test edition should display testcases * Whitespace fixes * Make testcase tiddler tempalte link to itself * Styling tweaks * Docs improvements * Styling tweaks * Run the new tw5.com testcases in the test edition * Update data widget to display its content in JSON * Add testcase convenience procedure * Clearer testcases for data widget, and docs tweaks * Don't expect our intentionally failing test to pass * Extend testcase default template so that the display format can be chosen It is selected by setting the variable "displayFormat" * DataWidget docs typo * Mark Geospatial plugin as experimental * Update to Leaflet v1.9.4 * Remove unneeded template Left over from when the testcase widget was first implemented * Don't hide the volcanoes of the world data set * Update Flickr demo docs * Fix subtle typo that was preventing popups from working correctly * Go back to hiding the volcanoes of the world by default Too much data for a small device now that the markers are displayed correctly * Clarify docs for tm-request-location * Update modified testcase from master * Prepare for merging --------- Co-authored-by: btheado <brian.theado@gmail.com> Co-authored-by: Drevarr <drevarr@gmail.com>
* fr-FR description of the `stability` core field * fr-FR translations for testcase-related description strings * fr-FR translations for testcase-related palette descriptions * fr-FR translation for emergency download button caption * Replace operand with parameters in fr-FR description of isfilteroperator * fr-FR description of the `class` core field * fr-FR update of a --command example * better fr-FR description for main types * Clearer fr-FR description of the `server` command * Complete the fr-FR translation for the --savewikifolder description
* fix: import lingo macro when render title * refactor: only import lingo macro for title to save memory * Revert "refactor: only import lingo macro for title to save memory" This reverts commit 36bf084.
|
Thank you @catter-fly, much appreciated, and thanks for your patience. |
|
Thanks @catter-fly these changes are now merged in 789d64f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added thumbnail macro parameters, as well as some examples thereabouts.
Did some link-dusting via the Missing tab.