Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rockspec: use git+https:// for git repository URL #27

Merged
merged 1 commit into from
Nov 22, 2021
Merged

rockspec: use git+https:// for git repository URL #27

merged 1 commit into from
Nov 22, 2021

Conversation

Totktonada
Copy link
Contributor

@Totktonada Totktonada commented Nov 9, 2021

GitHub is going to disable unencrypted Git protocol, so git:// URLs
will stop working soon (see 1).

Bumped the rockspec revision.

Copy link
Owner

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing the rockspec also requires changing the revision number. Both in the rockspec file, as well as renaming the rockspec file.

would you mind adding that to the PR?

GitHub is going to disable unencrypted Git protocol, so `git://` URLs
will stop working soon (see [1]).

Bumped the rockspec revision.

[1]: https://github.blog/2021-09-01-improving-git-protocol-security-github/
@Totktonada
Copy link
Contributor Author

Bumped the rockspec revision (and renamed the file accordingly).

@Totktonada
Copy link
Contributor Author

@Tieske Are there any problems now? I resolved the review comments.

Copy link
Owner

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Totktonada thx for the update!

@Tieske Tieske merged commit e5d38bb into Tieske:master Nov 22, 2021
@Totktonada Totktonada deleted the Totktonada/fix-git-url-in-rockspec branch April 19, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants