Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse ISO 8601 comma-spec'd decimal seconds #31

Merged
merged 3 commits into from Jun 19, 2023

Conversation

rsk0
Copy link
Contributor

@rsk0 rsk0 commented Jun 16, 2023

ISO 8601 seems to say the decimal portion of seconds can be indicated with a comma*. At the very least I've seen Kafka server logs using them.

@Tieske
Copy link
Owner

Tieske commented Jun 16, 2023

got a link to the spec where it says that?

Copy link
Owner

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case please?

@rsk0
Copy link
Contributor Author

rsk0 commented Jun 17, 2023

got a link to the spec where it says that?

Please pardon my not making that clear.

While I can't without paying 155 Swiss francs see the spec directly myself, Wikipedia paraphrases it thus:

A decimal fraction may be added to the lowest order time element present in any of these representations. A decimal mark, either a comma or a dot, is used as a separator between the time element and its fraction. (Following ISO 80000-1 according to ISO 8601:1-2019,[26] it does not stipulate a preference except within International Standards, but with a preference for a comma according to ISO 8601:2004.[27])

@rsk0
Copy link
Contributor Author

rsk0 commented Jun 17, 2023

Can you add a test case please?

Of course! Where are my manners? Added.

@rsk0 rsk0 requested a review from Tieske June 18, 2023 00:00
Copy link
Owner

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@Tieske Tieske merged commit e309741 into Tieske:master Jun 19, 2023
@rsk0 rsk0 deleted the rsk0/iso8601_comma_for_decimal_seconds branch July 1, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants