Improve congestion control #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the data sent, and avoids any problems with the client corrupting it.
It's a general function and it's better to have that particular complexity in its own place.
Refine the previous method by interpolating the values we need. This reduces the effect of the problem that we cannot send enough ping packets.
Allows us to compare our computed congestion window with the underlying one used by the TCP layer.
CendioOssman
force-pushed
the
congestion
branch
from
fa66f77
to
8cf7163
Compare
|
Did a whole bunch of test runs over various network conditions (using simulator): All cases showed improvement or similar behaviour to the old system (generally latency > 100ms showed improvement). |
This was referenced May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series makes the congestion control a bit more responsive and it should be able to make better decisions.
If you use TigerVNC over a high latency connection then please test and report back. Note that these changes are in the server, not the client.