Fix pylint warning: super-init-not-called #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Echelon9
commented
Dec 26, 2016
Echelon9
commented
Tigge
requested changes
Dec 27, 2016
| @@ -38,6 +38,7 @@ def makedirs_if_not_exists(path): | |||
|
|
|||
| class XDGError(Exception): | |||
| def __init__(self, message): | |||
| super(XDGError, self).__init__(message) | |||
| self.message = message | |||
There was a problem hiding this comment.
This line can be removed when the super init is called, right?
There was a problem hiding this comment.
Change made.
As the message is just being passed up to the super class and not actually used in XDGError(), I think this is fine.
************* Module antfs_cli.utilities W: 40, 4: __init__ method from base class 'Exception' is not called (super-init-not-called) Global evaluation ----------------- Your code has been rated at 6.77/10 (previous run: 6.72/10, +0.05)
Echelon9
force-pushed
the
fix/pylint-exception-super-init
branch
from
cfe325c
to
125c350
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.