New delete fragments endpoints #279
Conversation
anastasop
force-pushed
the
new-delete-fragments-endpoints
branch
from
d9d6960
to
158ea63
Compare
KiterLuc
force-pushed
the
new-delete-fragments-endpoints
branch
from
1137117
to
70d03fb
Compare
anastasop
force-pushed
the
new-delete-fragments-endpoints
branch
from
348f516
to
8490cdf
Compare
anastasop
force-pushed
the
new-delete-fragments-endpoints
branch
3 times, most recently
from
a453158
to
83cf0db
Compare
anastasop
force-pushed
the
new-delete-fragments-endpoints
branch
from
83cf0db
to
9b4b341
Compare
|
@snagles @thetorpedodog This is the final PR to support TileDB 2.18 and tag 0.24.0 |
| list = append(list, cfuri) | ||
| } | ||
|
|
||
| ret := C.tiledb_array_delete_fragments_list(tdbCtx.tiledbContext, curi, (**C.char)(unsafe.Pointer(&list[0])), C.size_t(len(list))) |
There was a problem hiding this comment.
This is probably something we should handle more broadly in the future, but you can use unsafe.SliceData to get the address of the start of a slice.
There was a problem hiding this comment.
Yes that was the initial code but needed to revert because there are some go1.19 installations and 1.19 does not have SliceData
array_test.go
Outdated
| err = array.Open(TILEDB_WRITE) | ||
| require.NoError(t, err) | ||
| for i := 1; i <= 10; i += 2 { | ||
| time.Sleep(100 * time.Millisecond) |
There was a problem hiding this comment.
can you add a note explaining why this is here?
There was a problem hiding this comment.
local disk is too fast and i needed fragments to have some time distance between them
array_test.go
Outdated
| err = array.Open(TILEDB_WRITE) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
For situations where the function returns just an error, maybe require.NoError(t, array.Open(TILEDB_WRITE)) etc.?
|
|
||
| // HandleArrayDeleteFragmentsTimestampsRequest is used by TileDB cloud to handle DeleteFragments with tiledb:// uris | ||
| func HandleArrayDeleteFragmentsTimestampsRequest(context *Context, array *Array, buffer *Buffer, serializationType SerializationType) error { | ||
| ret := C.tiledb_handle_array_delete_fragments_timestamps_request(context.tiledbContext, array.tiledbArray, |
There was a problem hiding this comment.
do we need to runtime.KeepAlive the buffer or anything else here?
There was a problem hiding this comment.
added them for safety
anastasop
force-pushed
the
new-delete-fragments-endpoints
branch
from
9b4b341
to
0087e4f
Compare
This implements the 2 new endpoints
tiledb_array_delete_fragments_v2andtiledb_array_delete_fragments_listfor the upcoming TileDB core 2.18.0