Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental build tag. #302

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

NullHypothesis
Copy link
Contributor

@NullHypothesis NullHypothesis commented Apr 3, 2024

This PR removes all experimental build constraints. In addition, this PR adds the suffix "_experimental.go" to all files that make use of experimental TileDB-Core functionality. For posterity, here's the shell script I wrote to determine what files use experimental functionality:

#!/usr/bin/env bash

for file in $(find . -name "*.go"); do
	exp=0

	for func in $(grep -o 'tiledb_[a-z_]*(' "$file"); do
		# Is the function defined in a header file that has "experimental" in it?
		header_file=$(grep -lr "TILEDB_EXPORT.*$func" /usr/local/include/tiledb)
		if [[ $header_file == *"experimental"* ]]; then
				exp=1
				break
		fi
	done
	if [ "$exp" -eq 1 ]; then
		echo "$file contains experimental functions."
	else
		if [ $(grep -c '#include <tiledb/tiledb_experimental.h>' "$file") -gt 0 ]; then
			echo "$file includes experimental header but uses no experimental functions."
		fi
	fi	
done

To make it clear which files use experimental TileDB-Core functions, this
commit renames these files to end with "_experimental.go" or
"_experimental_test.go", respectively.
@NullHypothesis NullHypothesis marked this pull request as ready for review April 4, 2024 16:20
@TileDB-Inc TileDB-Inc deleted a comment from shortcut-integration bot Apr 4, 2024
Copy link
Collaborator

@snagles snagles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have some other references in .github/workflows/tiledb-go.yml but otherwise LGTM pending that cleaned up

@NullHypothesis NullHypothesis merged commit 83e8685 into master Apr 4, 2024
7 checks passed
@NullHypothesis NullHypothesis deleted the phw/sc-39069/remove-experimental-build-tag branch April 4, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants