Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Attr To Pure Python (1/3) #1326

Merged
merged 1 commit into from Oct 6, 2022
Merged

Move Attr To Pure Python (1/3) #1326

merged 1 commit into from Oct 6, 2022

Conversation

nguyenv
Copy link
Collaborator

@nguyenv nguyenv commented Sep 17, 2022 •
edited

This is a subset of #1188. I'm separating into multiple PRs because it's becoming too big and unwieldy to change and review everything in one go.

@nguyenv nguyenv marked this pull request as ready for review September 17, 2022 05:56
@nguyenv nguyenv changed the title Move Attr To Pure Python Move Attr To Pure Python (1/3) Sep 20, 2022
@nguyenv nguyenv mentioned this pull request Sep 20, 2022
Merged
ihnorton
ihnorton approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 nice work!

tiledb/indexing.pyx Outdated Show resolved Hide resolved
tiledb/indexing.pyx Outdated Show resolved Hide resolved
@nguyenv nguyenv force-pushed the viviannguyen/pybind11-attr branch 2 times, most recently from ef17363 to e51dfbc Compare October 5, 2022 16:40
@nguyenv nguyenv merged commit bdd4bdb into dev Oct 6, 2022
@nguyenv nguyenv deleted the viviannguyen/pybind11-attr branch October 6, 2022 16:20
nguyenv added a commit that referenced this pull request Oct 18, 2022
@nguyenv
Revert "Move Attr From Cython to Pure Python (#1326)"
1ff512d 
* This reverts commit bdd4bdb.
* There are issues with the lifetime of `Context` in multiprocess
  settings as observed in cloud Jupyter notebooks and dask.
nguyenv added a commit that referenced this pull request Oct 19, 2022
@nguyenv
Revert "Move Attr From Cython to Pure Python (#1326)" (#1372)
ec35345
nguyenv added a commit that referenced this pull request Oct 20, 2022
@nguyenv
Revert "Move Attr From Cython to Pure Python (#1326)"
d00718b 
* This reverts commit bdd4bdb.
* There are issues with the lifetime of `Context` in multiprocess
  settings as observed in cloud Jupyter notebooks and dask.
nguyenv added a commit that referenced this pull request Nov 1, 2022
@nguyenv
Move Attr From Cython to Pure Python
b20ee6c 
* Revert "Revert "Move `Attr` From Cython to Pure Python (#1326)" (#1372)"
* This reverts commit ec35345.
@nguyenv nguyenv mentioned this pull request Nov 1, 2022
Merged
nguyenv added a commit that referenced this pull request Nov 10, 2022
@nguyenv
Move Attr From Cython to Pure Python
2f0f698 
* Revert "Revert "Move `Attr` From Cython to Pure Python (#1326)" (#1372)"
* This reverts commit ec35345.
nguyenv added a commit that referenced this pull request Nov 10, 2022
@nguyenv
Move Attr From Cython to Pure Python (#1411)
fd54b06 
* Revert "Revert "Move `Attr` From Cython to Pure Python (#1326)" (#1372)"
* This reverts commit ec35345.
* No longer errors out when running Dask tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nguyenv @ihnorton