Move Domain and Dim Into Pure Python (2/3)
#1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenv
force-pushed
the
viviannguyen/pybind11-dom-dim
branch
2 times, most recently
from
67f184c
to
a59b084
Compare
nguyenv
force-pushed
the
viviannguyen/pybind11-dom-dim
branch
from
a59b084
to
2f81560
Compare
nguyenv
force-pushed
the
viviannguyen/pybind11-dom-dim
branch
from
2f81560
to
cd0f25e
Compare
nguyenv
added a commit
that referenced
this pull request
Oct 27, 2022
nguyenv
force-pushed
the
viviannguyen/pybind11-dom-dim
branch
from
f1bb555
to
c5b5a7a
Compare
ihnorton
reviewed
Dec 5, 2022
There was a problem hiding this comment.
Let's talk through the design a bit more here. _lt_obj arguments don't quite seem right. __init__ methods should take arguments that are used to construct the class, and those _lt_obj arguments could be moved into a staticmethod factor constructor which forwards to __init__. But I want to make sure I understand why those are necessary (similar to the next point)
nguyenv
force-pushed
the
viviannguyen/pybind11-dom-dim
branch
from
c5b5a7a
to
4f26b9c
Compare
ihnorton
approved these changes
Dec 20, 2022
|
|
||
| super().__init__(self._ctx, name, dim_datatype, domain_array, tile_size_array) | ||
|
|
||
| if filters is not None: |
There was a problem hiding this comment.
see if we can move this to the constructor
There was a problem hiding this comment.
I think it is easier to just leave it as is since the create function does not take in a filter list argument.
https://github.com/TileDB-Inc/TileDB/blob/dev/tiledb/sm/cpp_api/dimension.h#L430-L478
nguyenv
force-pushed
the
viviannguyen/pybind11-dom-dim
branch
from
4f26b9c
to
d84a686
Compare
nguyenv
added a commit
that referenced
this pull request
Dec 22, 2022
* This should have been reverted before merging #1327, but I forgot to modify
nguyenv
added a commit
that referenced
this pull request
Dec 22, 2022
* This should have been reverted before merging #1327, but I forgot to modify
nguyenv
added a commit
that referenced
this pull request
Dec 22, 2022
* This should have been reverted before merging #1327, but I forgot to modify
nguyenv
added a commit
that referenced
this pull request
Dec 22, 2022
* This should have been reverted before merging #1327, but I forgot to modify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of #1188. Includes changes from #1326.