Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Array.query in docs and improve docs in general #1965

Merged
merged 9 commits into from
May 18, 2024
Merged

Add Array.query in docs and improve docs in general #1965

merged 9 commits into from
May 18, 2024

Conversation

kounelisagis
Copy link
Member

@kounelisagis kounelisagis commented May 13, 2024 •
edited

  • Added Array.query in docs, both SparseArray and DenseArray.
  • Fixed some minor errors/warnings while building docs like importing modules from tiledb.libtiledb instead of tiledb.
  • Setting default language for docs - it was causing warning.
  • Fixed some typos, like double 'a'.
  • Addressed the issue with new __repr__ of OrderedDict in Python 3.12 using np.testing.assert_equal.

@kounelisagis
Copy link
Member Author

query() is included for both.

@kounelisagis kounelisagis marked this pull request as ready for review May 13, 2024 17:16
ihnorton
ihnorton approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing the one comment inline about doc for aliased classes.

doc/source/python-api.rst Outdated Show resolved Hide resolved
@kounelisagis kounelisagis force-pushed the agis/sc-47147/array-query-reference-docs-not-rendering branch from b54a118 to ba68c93 Compare May 17, 2024 16:20
@kounelisagis kounelisagis changed the title Add Array.query in docs Add Array.query in docs and improve docs in general May 17, 2024
ihnorton
ihnorton approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, LGTM!

@ihnorton ihnorton merged commit 5b1f60e into dev May 18, 2024
34 checks passed
@ihnorton ihnorton deleted the agis/sc-47147/array-query-reference-docs-not-rendering branch May 18, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

@Shelnutt2 Shelnutt2 Awaiting requested review from Shelnutt2

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kounelisagis @ihnorton