Adjust timesteps in unit tests to make macOS less likely to miss #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronwolen
approved these changes
Jul 28, 2021
ihnorton
reviewed
Jul 28, 2021
There was a problem hiding this comment.
FWIW, in TileDB-Py we write at fixed values in order to make the tests deterministic: https://github.com/TileDB-Inc/TileDB-Py/blob/425f66781d2fba40950da4d073c3661a10630319/tiledb/tests/test_libtiledb.py#L1220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preceding PR stumbles twice on macOS in new-ish unit tests which check time traveling / vacuuming to assert it all works, and apparently have a subtle race condition leading to two re-run two of the last three runs on macOS.
The changed values here, essentially shifting 'half' a timestep instead of full timestep, appear to be more robust.