New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional polish on show methods #345
Additional polish on show methods #345
Conversation
This pull request has been linked to Shortcut Story #12282: Expand R-UDF validation coverage: make sure essential API calls work. |
A re-run of CI at GitHub resolved the flakyness caused earlier by network / remote site issues. |
Looks good to me -- thanks @eddelbuettel !! |
My penny-dropping mechanism had a malfunction last week so I was overly slow in groking what you needed. Once I did it was just a question of suggesting a different touch here or there. |
PR #342 is really good and gets us almost to the finish line of not relying on core code (to
stdout
) for object display and adding a numer of missingshow()
methods.It tickled an error an real
penguins
data set (withNA
values, as opposed to the cleansed one in cloud use) which I fixed that. While at it, I also made the code a little tighter and more idiomatic (and removed use oftry
). I apologise for the whitespace changes but I am quite used to how ESS typesets in base R defaults and this brings methods in further to the left.Please have a look with your test arrays, it it is looking ok on the ones I tried.
(The last commit was needed or else one test on
UINT32
would balk here. I am not sure how that didn't come up when we looked at the PR that brought it in. I should also have caught the use oftiledb_dense
there which we try to phase out / will remove next month.)