Additional polish on show methods#345
Merged
johnkerl merged 7 commits intokerl/sc-12282-array-schema-showfrom Jan 10, 2022
Merged
Additional polish on show methods#345johnkerl merged 7 commits intokerl/sc-12282-array-schema-showfrom
johnkerl merged 7 commits intokerl/sc-12282-array-schema-showfrom
Conversation
|
This pull request has been linked to Shortcut Story #12282: Expand R-UDF validation coverage: make sure essential API calls work. |
Contributor
Author
|
A re-run of CI at GitHub resolved the flakyness caused earlier by network / remote site issues. |
Contributor
|
Looks good to me -- thanks @eddelbuettel !! |
Contributor
Author
|
My penny-dropping mechanism had a malfunction last week so I was overly slow in groking what you needed. Once I did it was just a question of suggesting a different touch here or there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #342 is really good and gets us almost to the finish line of not relying on core code (to
stdout) for object display and adding a numer of missingshow()methods.It tickled an error an real
penguinsdata set (withNAvalues, as opposed to the cleansed one in cloud use) which I fixed that. While at it, I also made the code a little tighter and more idiomatic (and removed use oftry). I apologise for the whitespace changes but I am quite used to how ESS typesets in base R defaults and this brings methods in further to the left.Please have a look with your test arrays, it it is looking ok on the ones I tried.
(The last commit was needed or else one test on
UINT32would balk here. I am not sure how that didn't come up when we looked at the PR that brought it in. I should also have caught the use oftiledb_densethere which we try to phase out / will remove next month.)