Update scale filter option setter #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #24531: Update tiledb_filter options use for scale filter. |
aaronwolen
approved these changes
Jan 6, 2023
eddelbuettel
added a commit
that referenced
this pull request
Jan 6, 2023
* Update scale filter option setter for factor, offset and bytewidth * Tweak a test value and debug message level
eddelbuettel
added a commit
that referenced
this pull request
Jan 6, 2023
* Update scale filter option setter (#503) * Update scale filter option setter for factor, offset and bytewidth * Tweak a test value and debug message level * Release 0.17.1 * Updated pkgdown documentation for 0.17.1 * Update NEWS.md [ci skip] * Uncomment TILEDB_DEPRECATED for this release * Update pkgdown once more [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the filter option setter for the float scale filter which had previously failed to correctly use the
doubleanduint64_ttypes for its three options. This was revealed when testing with the latest merges todevin TileDB Core.No other code changes.