Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TileDB 2.15.2 #541

Merged
merged 5 commits into from
Apr 26, 2023
Merged

Use TileDB 2.15.2 #541

merged 5 commits into from
Apr 26, 2023

Conversation

eddelbuettel
Copy link
Member

This PR updates the package preference to TileDB 2.15.2.

No code change. One change to CI setup for macOS where CRAN broke the link along with the R 4.3.0 release.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #28269: Use TileDB 2.15.2.

@eddelbuettel eddelbuettel marked this pull request as ready for review April 26, 2023 14:08
@eddelbuettel
Copy link
Member Author

Throwing a quick 🦇 signal at @jeroen : I am seeing at devel-ucrt failure here.

 Error: Error: Failed to resolve R version devel-ucrt at \
      https://api.r-hub.io/rversions/resolve/devel-ucrt/win.

Is that related / would that be fixed by the very kind PR TileDB-Inc/TileDB#4061 you dropped the other day for core (and which is still open because we had likely unrelated colletaral damage and were generally "busy" as usual) ?

@jeroen
Copy link
Contributor

jeroen commented Apr 26, 2023

@eddelbuettel no that is unrelated. You should remove devel-ucrt from your build matrix here:

{ windows: windows-2022, r: devel-ucrt }

devel-ucrt was a transition measure 1+ years ago. All builds of R after 4.2 have been ucrt, the devel-ucrt special case no longer exists.

@eddelbuettel
Copy link
Member Author

I actually wondered about that exact same point the other day. We 'had' three for (non-ucrt) 32 + 64 plus (ucrt, then very new) 64 bit.

Is there a simple way to have a r-rel and r-dev stanza on Windows? I can of course trivially do that on Linux, even with container, and eg do so for Rcpp and have for eons. Maybe I'll page you off-line.

Will unplug this. So matrix should just be

          { windows: windows-2019, r: release    },
          { windows: windows-2022, r: devel      }

or should I standardize on 2022 for both while I am at it?

@jeroen
Copy link
Contributor

jeroen commented Apr 26, 2023

It is best to use windows 2022 (or just windows-latest), because older versions of Windows not support utf-8. TK has blogged about that somewhere.

@eddelbuettel
Copy link
Member Author

So windows-latest it is. Thanks so much for quick dispenaation of Windows build wisdom. Much appreciated!

@eddelbuettel eddelbuettel merged commit 725d7c0 into master Apr 26, 2023
@eddelbuettel eddelbuettel deleted the de/sc-28269/tiledb_2_15_2 branch April 26, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants