Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct domain getter for uint32, uint64, int64 cases #266

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Jun 25, 2021

This PR addresses an issue highlighted by @aaronwolen with a VCF example having uint32_t indices (with values in excess of INT_MAX) which were not queried correctly from a higher-level getter in the package. This now works for uint32_t, uint64_t and int64_t by updating some remaining legacy code and switching to integer64 return values.

For the array in question:

> library(tiledb)
TileDB R 0.9.4 with TileDB Embedded 2.4.0. See https://tiledb.com for more information.
> vcf <- tiledb::tiledb_array("tiledb://TileDB-Inc/vcf-1kg-phase3-data")
> tiledb::domain(tiledb::dimensions(tiledb::schema(vcf))[[2]])
integer64
[1] 0          4294967294
> 

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #8471: Robustify domain getter for uint32, uint64, int64.

Copy link
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the quick turnaround!

@eddelbuettel eddelbuettel merged commit 05c4c14 into master Jun 25, 2021
@eddelbuettel eddelbuettel deleted the de/ch8471/uint_domain_getters branch June 25, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants