Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert a sorting of factor levels and process as given by user #594

Merged
merged 2 commits into from Sep 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
@@ -1,6 +1,6 @@
Package: tiledb
Type: Package
Version: 0.21.0.4
Version: 0.21.0.5
Title: Universal Storage Engine for Sparse and Dense Multidimensional Arrays
Authors@R: c(person("TileDB, Inc.", role = c("aut", "cph")),
person("Dirk", "Eddelbuettel", email = "dirk@tiledb.com", role = "cre"))
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Expand Up @@ -10,6 +10,10 @@

* Use of TileDB Embedded was upgraded to release 2.17.1 (#593)

## Bug Fixes

* An added sorting of factor levels insert has been reverted (#594)


# tiledb 0.21.0

Expand Down
5 changes: 0 additions & 5 deletions R/ArraySchemaEvolution.R
Expand Up @@ -101,11 +101,6 @@ tiledb_array_schema_evolution_add_enumeration <- function(object, name, enums, o
"The 'enumlist' argument must be a character object" = is.character(enums),
"This function needs TileDB 2.17.0 or later" = tiledb_version(TRUE) >= "2.17.0",
"The 'ctx' argument must be a Context object" = is(ctx, "tiledb_ctx"))
srted <- sort(enums)
if (!isTRUE(all.equal(enums, srted))) {
warning("Enumeration levels were not sorted so rearranging.")
enums <- srted
}
object@ptr <- libtiledb_array_schema_evolution_add_enumeration(ctx@ptr, object@ptr, name,
enums, FALSE, ordered)
invisible(object)
Expand Down