Extend parse_query_condition to use new 'IN' and 'NOT_IN' queries #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
requested review from
davisp,
ihnorton,
aaronwolen,
johnkerl,
awenocur and
mojaveazure
|
This pull request has been linked to Shortcut Story #34849: Extend |
awenocur
approved these changes
Sep 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extend #597 but adding support for the new (faster) vector set comparisons to
parse_query_conditions.As
parse_query_conditionsstarts of with a syntactially valid R expression, we cannot useINandNOT_INwhich are not known operators. So we reuse the existing%in%and, as commonly done, locally defineA few new tests
will behave been added toobutand it (of course) passes all existing tests intest_querycondion.R.Context: single-cell-data/TileDB-SOMA#1742