Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust serialized query buffer sizes #2115

Merged

Conversation

Shelnutt2
Copy link
Member

@Shelnutt2 Shelnutt2 commented Mar 3, 2021

This change the client/server flow to always send the server the original user requested buffer sizes. This solves a bug in which with serialized queries incompletes would cause the "server" to use smaller buffers for each iteration of the incomplete query. This yield decreasing performance as the buffers approached zero. The fix here lets the server always get the original user's buffer size.

TYPE: BUG
DESC: Always use original buffer size in serialized read queries serverside.

@Shelnutt2 Shelnutt2 requested a review from joe-maley March 3, 2021 13:51
@shortcut-integration
Copy link

@Shelnutt2 Shelnutt2 force-pushed the sethshelnutt/ch5476/incomplete-queries-which-round-trip-through branch from 580bca0 to 95eecac Compare March 3, 2021 13:52
github-actions bot added a commit that referenced this pull request Mar 3, 2021
This change the client/server flow to always send the server the
original user requested buffer sizes. This solves a bug in which with
serialized queries incompletes would cause the "server" to use smaller
buffers for each iteration of the incomplete query. This yield
decreasing performance as the buffers approached zero. The fix here lets
the server always get the original user's buffer size.
@Shelnutt2 Shelnutt2 force-pushed the sethshelnutt/ch5476/incomplete-queries-which-round-trip-through branch from 33a0a76 to 4fe990b Compare March 4, 2021 00:20
@Shelnutt2 Shelnutt2 merged commit 963f91b into dev Mar 4, 2021
@Shelnutt2 Shelnutt2 deleted the sethshelnutt/ch5476/incomplete-queries-which-round-trip-through branch March 4, 2021 13:54
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2021

The backport to release-2.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.2 release-2.2
# Navigate to the new working tree
cd .worktrees/backport-release-2.2
# Create a new branch
git switch --create backport-2115-to-release-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 963f91b72c40933a593a5f4d4026359ad52f7556
# Push it to GitHub
git push --set-upstream origin backport-2115-to-release-2.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.2

Then, create a pull request where the base branch is release-2.2 and the compare/head branch is backport-2115-to-release-2.2.

Shelnutt2 added a commit that referenced this pull request Mar 4, 2021
Adjust serialized query buffer sizes

This change the client/server flow to always send the server the
original user requested buffer sizes. This solves a bug in which with
serialized queries incompletes would cause the "server" to use smaller
buffers for each iteration of the incomplete query. This yield
decreasing performance as the buffers approached zero. The fix here lets
the server always get the original user's buffer size.
Shelnutt2 added a commit that referenced this pull request Mar 4, 2021
Adjust serialized query buffer sizes

This change the client/server flow to always send the server the
original user requested buffer sizes. This solves a bug in which with
serialized queries incompletes would cause the "server" to use smaller
buffers for each iteration of the incomplete query. This yield
decreasing performance as the buffers approached zero. The fix here lets
the server always get the original user's buffer size.
Shelnutt2 added a commit that referenced this pull request Mar 12, 2021
This adds proper server side conditional handling for buffer sizes. In
the original patch in [#2115](#2115)
support was added for sending original user requested buffers.
Compatibility was maintianed for clients, but the server path missed
handling the older clients in the deserialization path.
Shelnutt2 added a commit that referenced this pull request Mar 12, 2021
This adds proper server side conditional handling for buffer sizes. In
the original patch in [#2115](#2115)
support was added for sending original user requested buffers.
Compatibility was maintained for clients, but the server path missed
handling the older clients in the deserialization path.
Shelnutt2 added a commit that referenced this pull request Mar 12, 2021
This adds proper server side conditional handling for buffer sizes. In
the original patch in [#2115](#2115)
support was added for sending original user requested buffers.
Compatibility was maintained for clients, but the server path missed
handling the older clients in the deserialization path.
github-actions bot pushed a commit that referenced this pull request Mar 12, 2021
This adds proper server side conditional handling for buffer sizes. In
the original patch in [#2115](#2115)
support was added for sending original user requested buffers.
Compatibility was maintained for clients, but the server path missed
handling the older clients in the deserialization path.
Shelnutt2 added a commit that referenced this pull request Mar 12, 2021
This adds proper server side conditional handling for buffer sizes. In
the original patch in [#2115](#2115)
support was added for sending original user requested buffers.
Compatibility was maintained for clients, but the server path missed
handling the older clients in the deserialization path.
Shelnutt2 added a commit that referenced this pull request Mar 12, 2021
This adds proper server side conditional handling for buffer sizes. In
the original patch in [#2115](#2115)
support was added for sending original user requested buffers.
Compatibility was maintained for clients, but the server path missed
handling the older clients in the deserialization path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants