New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust serialized query buffer sizes #2115
Merged
Shelnutt2
merged 2 commits into
dev
from
sethshelnutt/ch5476/incomplete-queries-which-round-trip-through
Mar 4, 2021
Merged
Adjust serialized query buffer sizes #2115
Shelnutt2
merged 2 commits into
dev
from
sethshelnutt/ch5476/incomplete-queries-which-round-trip-through
Mar 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to Clubhouse Story #5476: Incomplete queries which round trip through serialization have decreasing buffer sizes. |
Shelnutt2
force-pushed
the
sethshelnutt/ch5476/incomplete-queries-which-round-trip-through
branch
from
March 3, 2021 13:52
580bca0
to
95eecac
Compare
This change the client/server flow to always send the server the original user requested buffer sizes. This solves a bug in which with serialized queries incompletes would cause the "server" to use smaller buffers for each iteration of the incomplete query. This yield decreasing performance as the buffers approached zero. The fix here lets the server always get the original user's buffer size.
Shelnutt2
force-pushed
the
sethshelnutt/ch5476/incomplete-queries-which-round-trip-through
branch
from
March 4, 2021 00:20
33a0a76
to
4fe990b
Compare
joe-maley
approved these changes
Mar 4, 2021
Shelnutt2
deleted the
sethshelnutt/ch5476/incomplete-queries-which-round-trip-through
branch
March 4, 2021 13:54
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.2 release-2.2
# Navigate to the new working tree
cd .worktrees/backport-release-2.2
# Create a new branch
git switch --create backport-2115-to-release-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 963f91b72c40933a593a5f4d4026359ad52f7556
# Push it to GitHub
git push --set-upstream origin backport-2115-to-release-2.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.2 Then, create a pull request where the |
Shelnutt2
added a commit
that referenced
this pull request
Mar 4, 2021
Adjust serialized query buffer sizes This change the client/server flow to always send the server the original user requested buffer sizes. This solves a bug in which with serialized queries incompletes would cause the "server" to use smaller buffers for each iteration of the incomplete query. This yield decreasing performance as the buffers approached zero. The fix here lets the server always get the original user's buffer size.
Shelnutt2
added a commit
that referenced
this pull request
Mar 4, 2021
Adjust serialized query buffer sizes This change the client/server flow to always send the server the original user requested buffer sizes. This solves a bug in which with serialized queries incompletes would cause the "server" to use smaller buffers for each iteration of the incomplete query. This yield decreasing performance as the buffers approached zero. The fix here lets the server always get the original user's buffer size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change the client/server flow to always send the server the original user requested buffer sizes. This solves a bug in which with serialized queries incompletes would cause the "server" to use smaller buffers for each iteration of the incomplete query. This yield decreasing performance as the buffers approached zero. The fix here lets the server always get the original user's buffer size.
TYPE: BUG
DESC: Always use original buffer size in serialized read queries serverside.