Serialization backwards compatiblity w/buffer size #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #5901: Backwards compatibility broken with serialized buffer change. |
joe-maley
approved these changes
Mar 12, 2021
Shelnutt2
deleted the
sethshelnutt/ch5901/backwards-compatibility-broken-with-serialized
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds proper server side conditional handling for buffer sizes. In the original patch in #2115 support was added for sending original user requested buffers. Compatibility was maintained for clients, but the server path missed handling the older clients in the deserialization path.
TYPE: BUG
DESC: Handle compatibility with older client library versions for buffer sizes in serialization