Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for null pointer in query deserialization #2163

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

pavlosantoniou
Copy link
Contributor

@pavlosantoniou pavlosantoniou commented Mar 29, 2021

In function 'query_from_capnp' in file 'sm/serialization/query.cc', the pointer 'existing_offset_buffer_size_ptr' is checked for a null value instead of 'existing_buffer_size_ptr' before dereferencing the latter.


TYPE: BUG
DESC: Fix check for null pointer in query deserialization

@Shelnutt2
Copy link
Member

@pavlosantoniou Thank you for catching this and the fix. I'm curious, did you experience a crash related to this? Are you using TileDB Cloud or are you using the serialization calls independently?

Also please don't worry about the add_history_commit CI failure, its a relatively new action we have and seems to not work because of PR coming from a forked repo, we'll check on that separately.

@pavlosantoniou
Copy link
Contributor Author

@Shelnutt2 you are welcome, I stumbled upon this while exploring the code.

@joe-maley joe-maley merged commit 0c47ffe into TileDB-Inc:dev Mar 30, 2021
@joe-maley
Copy link
Contributor

Thank you @pavlosantoniou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants