Timestamp start/end for vacuuming/consolidation #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added configuration parameters to specify start and end times for fragment and array metadata consolidation and vacuuming. Also added more unit tests for opening an array at a starting timestamp. --- TYPE: IMPROVEMENT DESC: Timestamp start and end for vacuuming and consolidation
KiterLuc
force-pushed
the
lr/consolidation-timestamps
branch
from
a527774
to
6fa6a06
Compare
There was a problem hiding this comment.
Looks great. I added some very minor comments.
The main point for discussion is the following. When we consolidate fragments today, we create a .vac file with the consolidated fragments that are now "to be vacuumed". What happens if we vacuum a subset of them based on the timestamps? Do we remove the .vac file? Also what happens if we vacuum a second subset based on the timestamps, which overlaps with the previously vacuumed fragments. Will the code error out, or ignore a fragment that does not exist?
I think it is a good idea to add unit tests around those different scenarios around vacuuming subsets of fragments in the .vac file.
joe-maley
reviewed
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configuration parameters to specify start and end times for
fragment and array metadata consolidation and vacuuming.
Also added more unit tests for opening an array at a starting timestamp.
TYPE: IMPROVEMENT
DESC: Timestamp start and end for vacuuming and consolidation