Handle query condition causing incomplete query #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the query has a condition that filters out a tile, the tile needs to be removed from the query. The bug is when the tile remains but all cells have been filtered the query results in incomplete state since a tile remains but each submit skips the tile (since cell num is 0).
|
This pull request has been linked to Shortcut Story #12452: MariaDB string query returns incomplete with query condition. |
KiterLuc
approved these changes
Nov 24, 2021
Shelnutt2
deleted the
lucrancourt/sc-12452/mariadb-string-query-returns-incomplete-with
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the query has a condition that filters out a tile, the tile needs to be removed from the query. The bug is when the tile remains but all cells have been filtered the query results in incomplete state since a tile remains but each submit skips the tile (since cell num is 0). This is only effects 2.5,
devhas changed the code path and this no longer applies.TYPE: BUG
DESC: Remove tiles that are empty through being filtered with a query condition