Sparse unordered w/ dups reader: coord tiles management fix. #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clearing tiles during a var size overflow, we should only clear attribute tiles as coord tiles are counted in another memory budget and cleaned up later. There was a small logic bug where is_dim was used to determine if we were dealing with a dimension or not, but this variable was for the attribute currently being copied, and not the attribute considered for cleanup. --- TYPE: IMPROVEMENT DESC: Sparse unordered w/ dups reader: coord tiles management fix.
|
This pull request has been linked to Shortcut Story #16308: VCF segfault reading with TileDB 2.8.0-rc0. |
gspowley
approved these changes
Mar 30, 2022
KiterLuc
deleted the
lr/sparse-unordered-w-dups-tile-management-fix/ch16308
branch
github-actions bot
pushed a commit
that referenced
this pull request
Mar 30, 2022
When clearing tiles during a var size overflow, we should only clear attribute tiles as coord tiles are counted in another memory budget and cleaned up later. There was a small logic bug where is_dim was used to determine if we were dealing with a dimension or not, but this variable was for the attribute currently being copied, and not the attribute considered for cleanup. --- TYPE: IMPROVEMENT DESC: Sparse unordered w/ dups reader: coord tiles management fix.
ihnorton
pushed a commit
that referenced
this pull request
Mar 31, 2022
When clearing tiles during a var size overflow, we should only clear attribute tiles as coord tiles are counted in another memory budget and cleaned up later. There was a small logic bug where is_dim was used to determine if we were dealing with a dimension or not, but this variable was for the attribute currently being copied, and not the attribute considered for cleanup. --- TYPE: IMPROVEMENT DESC: Sparse unordered w/ dups reader: coord tiles management fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clearing tiles during a var size overflow, we should only clear
attribute tiles as coord tiles are counted in another memory budget and
cleaned up later. There was a small logic bug where is_dim was used to
determine if we were dealing with a dimension or not, but this variable
was for the attribute currently being copied, and not the attribute
considered for cleanup.
TYPE: BUG
DESC: Sparse unordered w/ dups reader: coord tiles management fix.