Implement delete_fragments API #3400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shelnutt2
reviewed
Jul 29, 2022
bekadavis9
force-pushed
the
rd/delete_fragments
branch
from
72935a1
to
f5c03b4
Compare
|
This pull request has been linked to Shortcut Story #15852: Implement delete_fragments API. |
bekadavis9
force-pushed
the
rd/delete_fragments
branch
from
f5c03b4
to
6c1f9af
Compare
bekadavis9
force-pushed
the
rd/delete_fragments
branch
from
6c1f9af
to
9c97363
Compare
Shelnutt2
approved these changes
Aug 19, 2022
bekadavis9
force-pushed
the
rd/delete_fragments
branch
from
c6bb5cc
to
5c81b7a
Compare
ihnorton
approved these changes
Aug 19, 2022
| CHECK(tiledb::test::num_fragments(array_name) == 3); | ||
| REQUIRE_THROWS_WITH( | ||
| array.delete_fragments(array_name, timestamp_start, timestamp_end), | ||
| Catch::Contains("Query type must be MODIFY_EXCLUSIVE")); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement delete_fragments API.
This API uses the existing
FragmentConsolidator::vacuumto:Note that this API can only be invoked on an array that is open with the new
QueryType::WRITE_EXCLUSIVE.[sc-15852]
TYPE: FEATURE
DESC: Implement delete_fragments API