Opt-in core-to-REST-server instrumentation #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
commented
Aug 7, 2022
johnkerl
commented
Aug 8, 2022
johnkerl
force-pushed
the
kerl/core-to-rest-instrumentation
branch
from
7c727be
to
c8ec5ac
Compare
johnkerl
force-pushed
the
kerl/core-to-rest-instrumentation
branch
from
e3bd25a
to
c3cdd37
Compare
ypatia
reviewed
Aug 9, 2022
ypatia
force-pushed
the
kerl/core-to-rest-instrumentation
branch
from
f5ccd91
to
06487d3
Compare
|
@ypatia is there anything else to do on this PR? If not can we approve it? |
It's ok for me, but let's have an approval from either @Shelnutt2 or @ihnorton before we merge |
|
As per @Shelnutt2's initial review we have:
|
ypatia
force-pushed
the
kerl/core-to-rest-instrumentation
branch
from
0bc196b
to
8eaa0ba
Compare
Shelnutt2
approved these changes
Aug 11, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
* Opt-in core-to-REST-server instrumentation * clang format * add flushing for real-time greppability * fix formatting * code-review feedback * Few improvements based on commenst + CI fix * remove flush which supported pipe-to-grep use-case * Address @Shelnutt2 initial review comments Co-authored-by: Ypatia Tsavliri <ypatia@tiledb.com>
Shelnutt2
pushed a commit
that referenced
this pull request
Aug 11, 2022
* Opt-in core-to-REST-server instrumentation * clang format * add flushing for real-time greppability * fix formatting * code-review feedback * Few improvements based on commenst + CI fix * remove flush which supported pipe-to-grep use-case * Address @Shelnutt2 initial review comments Co-authored-by: Ypatia Tsavliri <ypatia@tiledb.com> Co-authored-by: John Kerl <kerl.john.r@gmail.com> Co-authored-by: Ypatia Tsavliri <ypatia@tiledb.com>
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides crucial information on core-to-REST-server HTTP operations. This is essential for analyzing and minimizing remote-request latencies. An indispensable counterpart to Jaeger tracing, while Jaeger tracing isn't enough to give us a full picture on all interactions in all contexts. Having this in-core will make these performance numbers readily accessible where they're most needed, namely, in notebook environments.
TYPE: IMPROVEMENT
DESC: Opt-in core-to-REST-server instrumentation