-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opt-in core-to-REST-server instrumentation #3432
Conversation
7c727be
to
c8ec5ac
Compare
e3bd25a
to
c3cdd37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the good work! I added a few comments, I will push a new version to address them if you don't mind to save you the hustle, together with a small ordering fix in the config unit-tests that will make CI pass. HTH
f5ccd91
to
06487d3
Compare
@ypatia is there anything else to do on this PR? If not can we approve it? |
It's ok for me, but let's have an approval from either @Shelnutt2 or @ihnorton before we merge |
As per @Shelnutt2's initial review we have:
|
0bc196b
to
8eaa0ba
Compare
* Opt-in core-to-REST-server instrumentation * clang format * add flushing for real-time greppability * fix formatting * code-review feedback * Few improvements based on commenst + CI fix * remove flush which supported pipe-to-grep use-case * Address @Shelnutt2 initial review comments Co-authored-by: Ypatia Tsavliri <ypatia@tiledb.com>
* Opt-in core-to-REST-server instrumentation * clang format * add flushing for real-time greppability * fix formatting * code-review feedback * Few improvements based on commenst + CI fix * remove flush which supported pipe-to-grep use-case * Address @Shelnutt2 initial review comments Co-authored-by: Ypatia Tsavliri <ypatia@tiledb.com> Co-authored-by: John Kerl <kerl.john.r@gmail.com> Co-authored-by: Ypatia Tsavliri <ypatia@tiledb.com>
🚀 |
Provides crucial information on core-to-REST-server HTTP operations. This is essential for analyzing and minimizing remote-request latencies. An indispensable counterpart to Jaeger tracing, while Jaeger tracing isn't enough to give us a full picture on all interactions in all contexts. Having this in-core will make these performance numbers readily accessible where they're most needed, namely, in notebook environments.
TYPE: IMPROVEMENT
DESC: Opt-in core-to-REST-server instrumentation