Deletes: adding examples. #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds examples for deletes. --- TYPE: IMPROVEMENT DESC: Deletes: adding examples.
|
This pull request has been linked to Shortcut Story #20032: Deletes: write example.. |
ypatia
approved these changes
Aug 12, 2022
| // Prepare the vector that will hold the result. | ||
| // We take an upper bound on the result size, as we do not | ||
| // know a priori how big it is (since the array is sparse) | ||
| std::vector<int> data(3); |
There was a problem hiding this comment.
wouldn't the upper bound be 16 in that case for a 4x4 array?
Or you mean we don't know if any cells were deleted from our initial data that had a size of 3?
There was a problem hiding this comment.
I think the second case in your or question. This was copied from another example.
| * | ||
| * The MIT License | ||
| * | ||
| * @copyright Copyright (c) 2018-2022 TileDB, Inc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds examples for deletes.
TYPE: IMPROVEMENT
DESC: Deletes: adding examples.