Add abseil/absl to build via ExternalProject_Add #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #20101: Add Abseil to build. |
ihnorton
reviewed
Aug 17, 2022
Shelnutt2
reviewed
Aug 17, 2022
…tern and to check expected targets
|
Comments addressed. |
ihnorton
reviewed
Aug 18, 2022
Shelnutt2
reviewed
Aug 18, 2022
cmake/Modules/Findabsl_EP.cmake
Outdated
| -DBUILD_TESTING=OFF | ||
| -DCMAKE_PREFIX_PATH=${TILEDB_EP_INSTALL_PREFIX} | ||
| -DCMAKE_INSTALL_PREFIX=${TILEDB_EP_INSTALL_PREFIX} | ||
| -DCMAKE_CXX_FLAGS=-fPIC |
There was a problem hiding this comment.
Should this use the cmake_position_independent_code flag?
There was a problem hiding this comment.
PIC not verifiable as currently needed, removed
|
anticipate that options used to build may need adjustment when/if reach point of trying to use with (upgrading of) gcssdk |
ihnorton
approved these changes
Aug 19, 2022
ihnorton
pushed a commit
that referenced
this pull request
Aug 23, 2022
* add Crc32c to tiledb build via ExternalProject_Add * add 'prefix' underscore to transient option, add use that for transient build of crc32 until gcs eventually starts to need (to be merged after #3454, abseil/absl added to build) --- TYPE: FEATURE DESC: add Crc32c to tiledb build via ExternalProject_Add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add abseil/absl to build via ExternalProject_Add
TYPE: FEATURE
DESC: add abseil/absl to build via ExternalProject_Add