Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the check-formatting script in CI to format everything in test, not just test/src #3475

Merged
merged 3 commits into from Aug 23, 2022

Conversation

eric-hughes-tiledb
Copy link
Contributor

Change the check-formatting script in CI to format everything in test, not just test/src. We're using that directory more extensively than in the past.


TYPE: NO_HISTORY
DESC: Change the check-formatting script in CI to format everything in test, not just test/src

@eric-hughes-tiledb
Copy link
Contributor Author

The format test is failing in test/external/src/absl_link_test.cc, introduced in #3454 last Friday. There's a large block comment that's clang-format is mangling. @dhoke4tdb, since that's your code, would you reformat that in a way compatible with clang-format and push to the branch for this PR?

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ihnorton ihnorton merged commit b7b7a4e into dev Aug 23, 2022
@ihnorton ihnorton deleted the eh/format-everything-in-test branch August 23, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants