-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing query_type in array_open capnp #3616
Conversation
This pull request has been linked to Shortcut Story #22950: Array open v2 should set the query_type_. |
@Shelnutt2 you had a comment about backwards compatibility I think, that I didn't exactly get in the end, so please add a review comment here and I will try to address it. |
@@ -260,6 +262,13 @@ Status array_open_from_capnp( | |||
RETURN_NOT_OK(array->set_config(*decoded_config)); | |||
} | |||
|
|||
if (array_open_reader.hasQueryType()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
b234fb6
to
a645500
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.11 release-2.11
# Navigate to the new working tree
cd .worktrees/backport-release-2.11
# Create a new branch
git switch --create backport-3616-to-release-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 a3cd9c4d0f210a60cf007746b2631290fa6aa9af
# Push it to GitHub
git push --set-upstream origin backport-3616-to-release-2.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.11 Then, create a pull request where the |
Currently in Array open v2 we are not specifying in what "mode" we are requesting to open the array. Thus the Cloud side unconditionally opens the array in READ mode (https://github.com/TileDB-Inc/TileDB-Cloud-REST/blob/master/internal/arrays/v2/array.go#L252). This PR fixes this issue by adding a `query_type` CAPNP field to be used by Cloud to open the array. --- TYPE: BUG DESC: Add missing query_type in array_open capnp === * Add query_type in array_open capnp * build target update-serialization for windows (plus clang format) * Default initalize Array query_type to fix test failures * Fix CI warning Co-authored-by: dhoke4tdb <david.hoke@tiledb.com>
Currently in Array open v2 we are not specifying in what "mode" we are requesting to open the array. Thus the Cloud side unconditionally opens the array in READ mode (https://github.com/TileDB-Inc/TileDB-Cloud-REST/blob/master/internal/arrays/v2/array.go#L252). This PR fixes this issue by adding a `query_type` CAPNP field to be used by Cloud to open the array. --- TYPE: BUG DESC: Add missing query_type in array_open capnp === * Add query_type in array_open capnp * build target update-serialization for windows (plus clang format) * Default initalize Array query_type to fix test failures * Fix CI warning Co-authored-by: dhoke4tdb <david.hoke@tiledb.com>
Currently in Array open v2 we are not specifying in what "mode" we are requesting to open the array. Thus the Cloud side unconditionally opens the array in READ mode (https://github.com/TileDB-Inc/TileDB-Cloud-REST/blob/master/internal/arrays/v2/array.go#L252). This PR fixes this issue by adding a `query_type` CAPNP field to be used by Cloud to open the array. --- TYPE: BUG DESC: Add missing query_type in array_open capnp === * Add query_type in array_open capnp * build target update-serialization for windows (plus clang format) * Default initalize Array query_type to fix test failures * Fix CI warning Co-authored-by: dhoke4tdb <david.hoke@tiledb.com> Co-authored-by: Ypatia Tsavliri <ypatia@tiledb.com> Co-authored-by: dhoke4tdb <david.hoke@tiledb.com>
Currently in Array open v2 we are not specifying in what "mode" we are requesting to open the array. Thus the Cloud side unconditionally opens the array in READ mode (https://github.com/TileDB-Inc/TileDB-Cloud-REST/blob/master/internal/arrays/v2/array.go#L252).
This PR fixes this issue by adding a
query_type
CAPNP field to be used by Cloud to open the array.TYPE: BUG
DESC: Add missing query_type in array_open capnp