Add missing query_type in array_open capnp #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #22950: Array open v2 should set the query_type_. |
|
@Shelnutt2 you had a comment about backwards compatibility I think, that I didn't exactly get in the end, so please add a review comment here and I will try to address it. |
Shelnutt2
reviewed
Oct 31, 2022
| @@ -260,6 +262,13 @@ Status array_open_from_capnp( | |||
| RETURN_NOT_OK(array->set_config(*decoded_config)); | |||
| } | |||
|
|
|||
| if (array_open_reader.hasQueryType()) { | |||
Shelnutt2
approved these changes
Oct 31, 2022
ypatia
force-pushed
the
yt/ch22950/array_v2_should_set_query_type
branch
from
b234fb6
to
a645500
Compare
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.11 release-2.11
# Navigate to the new working tree
cd .worktrees/backport-release-2.11
# Create a new branch
git switch --create backport-3616-to-release-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 a3cd9c4d0f210a60cf007746b2631290fa6aa9af
# Push it to GitHub
git push --set-upstream origin backport-3616-to-release-2.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.11Then, create a pull request where the |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 1, 2022
Currently in Array open v2 we are not specifying in what "mode" we are requesting to open the array. Thus the Cloud side unconditionally opens the array in READ mode (https://github.com/TileDB-Inc/TileDB-Cloud-REST/blob/master/internal/arrays/v2/array.go#L252). This PR fixes this issue by adding a `query_type` CAPNP field to be used by Cloud to open the array. --- TYPE: BUG DESC: Add missing query_type in array_open capnp === * Add query_type in array_open capnp * build target update-serialization for windows (plus clang format) * Default initalize Array query_type to fix test failures * Fix CI warning Co-authored-by: dhoke4tdb <david.hoke@tiledb.com>
ypatia
added a commit
that referenced
this pull request
Nov 1, 2022
Currently in Array open v2 we are not specifying in what "mode" we are requesting to open the array. Thus the Cloud side unconditionally opens the array in READ mode (https://github.com/TileDB-Inc/TileDB-Cloud-REST/blob/master/internal/arrays/v2/array.go#L252). This PR fixes this issue by adding a `query_type` CAPNP field to be used by Cloud to open the array. --- TYPE: BUG DESC: Add missing query_type in array_open capnp === * Add query_type in array_open capnp * build target update-serialization for windows (plus clang format) * Default initalize Array query_type to fix test failures * Fix CI warning Co-authored-by: dhoke4tdb <david.hoke@tiledb.com>
ihnorton
pushed a commit
that referenced
this pull request
Nov 1, 2022
Currently in Array open v2 we are not specifying in what "mode" we are requesting to open the array. Thus the Cloud side unconditionally opens the array in READ mode (https://github.com/TileDB-Inc/TileDB-Cloud-REST/blob/master/internal/arrays/v2/array.go#L252). This PR fixes this issue by adding a `query_type` CAPNP field to be used by Cloud to open the array. --- TYPE: BUG DESC: Add missing query_type in array_open capnp === * Add query_type in array_open capnp * build target update-serialization for windows (plus clang format) * Default initalize Array query_type to fix test failures * Fix CI warning Co-authored-by: dhoke4tdb <david.hoke@tiledb.com> Co-authored-by: Ypatia Tsavliri <ypatia@tiledb.com> Co-authored-by: dhoke4tdb <david.hoke@tiledb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in Array open v2 we are not specifying in what "mode" we are requesting to open the array. Thus the Cloud side unconditionally opens the array in READ mode (https://github.com/TileDB-Inc/TileDB-Cloud-REST/blob/master/internal/arrays/v2/array.go#L252).
This PR fixes this issue by adding a
query_typeCAPNP field to be used by Cloud to open the array.TYPE: BUG
DESC: Add missing query_type in array_open capnp